third_party/WebKit/Source/modules/notifications/NotificationResourcesLoader.cpp - Issue 2091713002: Specialize base::IsWeakReceiver for Blink weak pointers to support base::Bind (1/5)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/notifications/NotificationResourcesLoader.cpp

Issue 2091713002: Specialize base::IsWeakReceiver for Blink weak pointers to support base::Bind (1/5) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: +#include for build fix Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/notifications/Notification.cpp ('k') | third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/notifications/NotificationResourcesLoader.cpp

diff --git a/third_party/WebKit/Source/modules/notifications/NotificationResourcesLoader.cpp b/third_party/WebKit/Source/modules/notifications/NotificationResourcesLoader.cpp

index b27cdc232b7ed1788236037d0aaaa5ab1108421e..559c5cccb772a1aa18ce9770bccf06b7cf80e21b 100644

--- a/third_party/WebKit/Source/modules/notifications/NotificationResourcesLoader.cpp

+++ b/third_party/WebKit/Source/modules/notifications/NotificationResourcesLoader.cpp

@@ -55,12 +55,12 @@ void NotificationResourcesLoader::start(ExecutionContext* executionContext, cons

size_t numActions = notificationData.actions.size();

m_pendingRequestCount = 2 /* icon and badge */ + numActions;

- loadImage(executionContext, notificationData.icon, bind(&NotificationResourcesLoader::didLoadIcon, WeakPersistentThisPointer<NotificationResourcesLoader>(this)));

- loadImage(executionContext, notificationData.badge, bind(&NotificationResourcesLoader::didLoadBadge, WeakPersistentThisPointer<NotificationResourcesLoader>(this)));

+ loadImage(executionContext, notificationData.icon, bind(&NotificationResourcesLoader::didLoadIcon, wrapWeakPersistent(this)));

+ loadImage(executionContext, notificationData.badge, bind(&NotificationResourcesLoader::didLoadBadge, wrapWeakPersistent(this)));

m_actionIcons.resize(numActions);

for (size_t i = 0; i < numActions; i++)

- loadImage(executionContext, notificationData.actions[i].icon, bind(&NotificationResourcesLoader::didLoadActionIcon, WeakPersistentThisPointer<NotificationResourcesLoader>(this), i));

+ loadImage(executionContext, notificationData.actions[i].icon, bind(&NotificationResourcesLoader::didLoadActionIcon, wrapWeakPersistent(this), i));

}

std::unique_ptr<WebNotificationResources> NotificationResourcesLoader::getResources() const