Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(744)

Issue 2091693005: Serialize only unserialized libraries on --resolve-only (Closed)

Created:
4 years, 5 months ago by Johnni Winther
Modified:
4 years, 5 months ago
Reviewers:
Harry Terkelsen
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Serialize only unserialized libraries on --resolve-only This speeds up batch-mode testing of serialization significantly: from 40 min to 10 min for language tests on my machine. R=het@google.com Committed: https://github.com/dart-lang/sdk/commit/a4a21f529a129ed721b5f85de63635984b0d06e8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -28 lines) Patch
M pkg/compiler/lib/src/compiler.dart View 2 chunks +13 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/dart2js.dart View 10 chunks +54 lines, -24 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
4 years, 5 months ago (2016-06-24 12:14:46 UTC) #2
Harry Terkelsen
lgtm
4 years, 5 months ago (2016-06-24 17:09:35 UTC) #3
Harry Terkelsen
On 2016/06/24 12:14:46, Johnni Winther wrote: >from 40 min to 10 min for language tests ...
4 years, 5 months ago (2016-06-24 17:11:26 UTC) #4
Johnni Winther
4 years, 5 months ago (2016-06-27 08:03:08 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a4a21f529a129ed721b5f85de63635984b0d06e8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698