Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Issue 2091693004: Revert of Amends the TypedArray constructor to use the path for primitives for all (Closed)

Created:
4 years, 6 months ago by Michael Achenbach
Modified:
4 years, 6 months ago
Reviewers:
bakkot, Dan Ehrenberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Amends the TypedArray constructor to use the path for primitives for all (patchset #3 id:40001 of https://codereview.chromium.org/2096873002/ ) Reason for revert: [Sheriff] Breaks layout tests. Please rebase upstream if intended: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/7691 Original issue's description: > Amends the TypedArray constructor to use the path for primitives for all > types of primitives, not just undefined, booleans, numbers, and strings. > (The missing cases were null and Symbol.) This is required by the > specification, and there are test262 tests which we were failing due to > this bug. > > BUG=v8:5124 > > Committed: https://crrev.com/f788bd9cce19815cba746e47bb65abfe25c16208 > Cr-Commit-Position: refs/heads/master@{#37234} TBR=littledan@chromium.org,bakkot@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5124 Committed: https://crrev.com/3f0ada1d84e8956213465cb30b48e66f83895e8f Cr-Commit-Position: refs/heads/master@{#37236}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -29 lines) Patch
M src/js/typedarray.js View 1 chunk +4 lines, -3 lines 0 comments Download
M test/mjsunit/es6/typedarray.js View 1 chunk +0 lines, -23 lines 0 comments Download
M test/test262/test262.status View 3 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Achenbach
Created Revert of Amends the TypedArray constructor to use the path for primitives for all
4 years, 6 months ago (2016-06-24 06:30:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2091693004/1
4 years, 6 months ago (2016-06-24 06:31:02 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-24 06:31:17 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-24 06:34:39 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3f0ada1d84e8956213465cb30b48e66f83895e8f
Cr-Commit-Position: refs/heads/master@{#37236}

Powered by Google App Engine
This is Rietveld 408576698