Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2091673002:
Make callers of FromUTC(Local)Exploded in third_party/ use new time API. (Closed)
|
Created:
4 years, 6 months ago by maksims (do not use this acc) Modified:
4 years, 5 months ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMake callers of FromUTC(Local)Exploded in third_party/ use new time API.
Use new time conversion API in accordance with
https://codereview.chromium.org/1988663002/
BUG=601908
Committed: https://crrev.com/3d0a1b68b407f0535052b62819f9e7bb68ee2a94
Cr-Commit-Position: refs/heads/master@{#403134}
Patch Set 1 #
Messages
Total messages: 30 (15 generated)
Description was changed from ========== third party time callers BUG= ========== to ========== Make callers of FromUTC(Local)Exploded in third_party/ use new time API. Use new time conversion API in accordance with https://codereview.chromium.org/1988663002/ BUG=601900 ==========
maksim.sisov@intel.com changed reviewers: + eroman@chromium.org, hshi@google.com, isherman@chromium.org
The CQ bit was checked by maksim.sisov@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Make callers of FromUTC(Local)Exploded in third_party/ use new time API. Use new time conversion API in accordance with https://codereview.chromium.org/1988663002/ BUG=601900 ========== to ========== Make callers of FromUTC(Local)Exploded in third_party/ use new time API. Use new time conversion API in accordance with https://codereview.chromium.org/1988663002/ BUG=601905 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
ptal
lgtm
On 2016/06/29 05:05:43, maksims wrote: > ptal Sorry, I'm not an owner for this code -- only for the compression_utils* files. So, I'll bow out of the code review.
isherman@chromium.org changed reviewers: - isherman@chromium.org
The CQ bit was checked by maksim.sisov@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
maksim.sisov@intel.com changed reviewers: + satorux@google.com
+ satorux@
It seems like I'm missing owners' LGTM
satorux@chromium.org changed reviewers: + satorux@chromium.org
lgtm. nice!
The CQ bit was checked by maksim.sisov@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Make callers of FromUTC(Local)Exploded in third_party/ use new time API. Use new time conversion API in accordance with https://codereview.chromium.org/1988663002/ BUG=601905 ========== to ========== Make callers of FromUTC(Local)Exploded in third_party/ use new time API. Use new time conversion API in accordance with https://codereview.chromium.org/1988663002/ BUG=601905 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== Make callers of FromUTC(Local)Exploded in third_party/ use new time API. Use new time conversion API in accordance with https://codereview.chromium.org/1988663002/ BUG=601905 ========== to ========== Make callers of FromUTC(Local)Exploded in third_party/ use new time API. Use new time conversion API in accordance with https://codereview.chromium.org/1988663002/ BUG=601905 Committed: https://crrev.com/3d0a1b68b407f0535052b62819f9e7bb68ee2a94 Cr-Commit-Position: refs/heads/master@{#403134} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/3d0a1b68b407f0535052b62819f9e7bb68ee2a94 Cr-Commit-Position: refs/heads/master@{#403134}
Message was sent while issue was closed.
Description was changed from ========== Make callers of FromUTC(Local)Exploded in third_party/ use new time API. Use new time conversion API in accordance with https://codereview.chromium.org/1988663002/ BUG=601905 Committed: https://crrev.com/3d0a1b68b407f0535052b62819f9e7bb68ee2a94 Cr-Commit-Position: refs/heads/master@{#403134} ========== to ========== Make callers of FromUTC(Local)Exploded in third_party/ use new time API. Use new time conversion API in accordance with https://codereview.chromium.org/1988663002/ BUG=601900 Committed: https://crrev.com/3d0a1b68b407f0535052b62819f9e7bb68ee2a94 Cr-Commit-Position: refs/heads/master@{#403134} ==========
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2125433002/ by maksim.sisov@intel.com. The reason for reverting is: Wrong bug number.
Message was sent while issue was closed.
Description was changed from ========== Make callers of FromUTC(Local)Exploded in third_party/ use new time API. Use new time conversion API in accordance with https://codereview.chromium.org/1988663002/ BUG=601900 Committed: https://crrev.com/3d0a1b68b407f0535052b62819f9e7bb68ee2a94 Cr-Commit-Position: refs/heads/master@{#403134} ========== to ========== Make callers of FromUTC(Local)Exploded in third_party/ use new time API. Use new time conversion API in accordance with https://codereview.chromium.org/1988663002/ BUG=601908 Committed: https://crrev.com/3d0a1b68b407f0535052b62819f9e7bb68ee2a94 Cr-Commit-Position: refs/heads/master@{#403134} ========== |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
