Make callers of FromUTC(Local)Exploded in google_apis/ use new time API.

google_apis/drive/time_util_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "google_apis/drive/time_util.h"
 
 #include "base/i18n/time_formatting.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/time/time.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace google_apis {
 namespace util {
 namespace {
 
 std::string FormatTime(const base::Time& time) {
   return base::UTF16ToUTF8(base::TimeFormatShortDateAndTime(time));
 }
 
 }  // namespace
 
 TEST(TimeUtilTest, GetTimeFromStringLocalTimezone) {
   // Creates local time objects from exploded structure.
   base::Time::Exploded exploded = {2013, 1, 0, 15, 17, 11, 35, 374};
-  base::Time local_time = base::Time::FromLocalExploded(exploded);
+  base::Time local_time;
+  EXPECT_TRUE(base::Time::FromLocalExploded(exploded, &local_time));
 
   // Creates local time object, parsing time string. Note that if there is
   // not timezone suffix, GetTimeFromString() will handle this as local time
   // with FromLocalExploded().
   base::Time test_time;
   ASSERT_TRUE(GetTimeFromString("2013-01-15T17:11:35.374", &test_time));
 
   // Compare the time objects.
   EXPECT_EQ(local_time, test_time);
 }
@@ skipping 12 matching lines @@
   EXPECT_TRUE(GetTimeFromString("2012-07-14T07:33:21.151+06:30", &test_time));
   EXPECT_EQ(FormatTime(target_time), FormatTime(test_time));
 
   // Tests negative offset.
   EXPECT_TRUE(GetTimeFromString("2012-07-13T18:33:21.151-06:30", &test_time));
   EXPECT_EQ(FormatTime(target_time), FormatTime(test_time));
 }
 
 TEST(TimeUtilTest, GetTimeFromStringBasic) {
   base::Time test_time;
+  base::Time out_time;
 
   // Test that the special timezone "Z" (UTC) is handled.
   base::Time::Exploded target_time1 = {2005, 1, 0, 7, 8, 2, 0, 0};
   EXPECT_TRUE(GetTimeFromString("2005-01-07T08:02:00Z", &test_time));
-  EXPECT_EQ(FormatTime(base::Time::FromUTCExploded(target_time1)),
-            FormatTime(test_time));
+
+  EXPECT_TRUE(base::Time::FromUTCExploded(target_time1, &out_time));
+  EXPECT_EQ(FormatTime(out_time), FormatTime(test_time));
 
   // Test that a simple timezone "-08:00" is handled
   // 17:57 - 8 hours = 09:57
   base::Time::Exploded target_time2 = {2005, 8, 0, 9, 17, 57, 0, 0};
   EXPECT_TRUE(GetTimeFromString("2005-08-09T09:57:00-08:00", &test_time));
-  EXPECT_EQ(FormatTime(base::Time::FromUTCExploded(target_time2)),
-            FormatTime(test_time));
+  EXPECT_TRUE(base::Time::FromUTCExploded(target_time2, &out_time));
+  EXPECT_EQ(FormatTime(out_time), FormatTime(test_time));
 
   // Test that milliseconds (.123) are handled.
   base::Time::Exploded target_time3 = {2005, 1, 0, 7, 8, 2, 0, 123};
   EXPECT_TRUE(GetTimeFromString("2005-01-07T08:02:00.123Z", &test_time));
-  EXPECT_EQ(FormatTime(base::Time::FromUTCExploded(target_time3)),
-            FormatTime(test_time));
+  EXPECT_TRUE(base::Time::FromUTCExploded(target_time3, &out_time));
+  EXPECT_EQ(FormatTime(out_time), FormatTime(test_time));
 }
 
 TEST(TimeUtilTest, FormatTimeAsString) {
   base::Time::Exploded exploded_time = {2012, 7, 0, 19, 15, 59, 13, 123};
-  base::Time time = base::Time::FromUTCExploded(exploded_time);
+  base::Time time;
+  EXPECT_TRUE(base::Time::FromUTCExploded(exploded_time, &time));
   EXPECT_EQ("2012-07-19T15:59:13.123Z", FormatTimeAsString(time));
 
   EXPECT_EQ("null", FormatTimeAsString(base::Time()));
 }
 
 TEST(TimeUtilTest, FormatTimeAsStringLocalTime) {
   base::Time::Exploded exploded_time = {2012, 7, 0, 19, 15, 59, 13, 123};
-  base::Time time = base::Time::FromLocalExploded(exploded_time);
+  base::Time time;
+  EXPECT_TRUE(base::Time::FromLocalExploded(exploded_time, &time));
   EXPECT_EQ("2012-07-19T15:59:13.123", FormatTimeAsStringLocaltime(time));
 
   EXPECT_EQ("null", FormatTimeAsStringLocaltime(base::Time()));
 }
 
 }  // namespace util
 }  // namespace google_apis