Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 2091643003: gpu, cmaa: Stringify shaders (Closed)

Created:
4 years, 6 months ago by dshwang
Modified:
4 years, 6 months ago
Reviewers:
adrian.belgun, piman
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu, cmaa: Stringify shaders BUG=535198 TEST=Run a WebGL app with Chrome started with "--enable-cmaa-shaders" CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/d81b3eaa8645508f2a4b208490ded879265b2a8d Cr-Commit-Position: refs/heads/master@{#401886}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix win build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1146 lines, -1132 lines) Patch
M gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc View 1 3 chunks +1146 lines, -1132 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
dshwang
piman, could you review? stringify shaders like cc/output/shader.cc without logic changes. rationale: - IDE prettify ...
4 years, 6 months ago (2016-06-23 17:04:10 UTC) #4
piman
lgtm
4 years, 6 months ago (2016-06-23 19:52:51 UTC) #5
adrian.belgun
Please fix the Windows build. LGTM https://codereview.chromium.org/2091643003/diff/1/gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc File gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc (right): https://codereview.chromium.org/2091643003/diff/1/gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc#newcode1357 gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc:1357: ); This breaks ...
4 years, 6 months ago (2016-06-24 10:47:47 UTC) #6
dshwang
Thanks for reviewing! https://codereview.chromium.org/2091643003/diff/1/gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc File gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc (right): https://codereview.chromium.org/2091643003/diff/1/gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc#newcode1357 gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc:1357: ); On 2016/06/24 10:47:46, adrian.belgun wrote: ...
4 years, 6 months ago (2016-06-24 15:56:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2091643003/40001
4 years, 6 months ago (2016-06-24 15:57:17 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 6 months ago (2016-06-24 17:15:42 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-24 17:17:35 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d81b3eaa8645508f2a4b208490ded879265b2a8d
Cr-Commit-Position: refs/heads/master@{#401886}

Powered by Google App Engine
This is Rietveld 408576698