|
|
Descriptiongpu, cmaa: Stringify shaders
BUG=535198
TEST=Run a WebGL app with Chrome started with "--enable-cmaa-shaders"
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Committed: https://crrev.com/d81b3eaa8645508f2a4b208490ded879265b2a8d
Cr-Commit-Position: refs/heads/master@{#401886}
Patch Set 1 #
Total comments: 2
Patch Set 2 : fix win build #Messages
Total messages: 15 (8 generated)
Description was changed from ========== gpu, cmaa: Stringify shaders BUG=535198 TEST=Run a WebGL app with Chrome started with "--enable-cmaa-shaders" ========== to ========== gpu, cmaa: Stringify shaders BUG=535198 TEST=Run a WebGL app with Chrome started with "--enable-cmaa-shaders" CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== gpu, cmaa: Stringify shaders BUG=535198 TEST=Run a WebGL app with Chrome started with "--enable-cmaa-shaders" CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== gpu, cmaa: Stringify shaders BUG=535198 TEST=Run a WebGL app with Chrome started with "--enable-cmaa-shaders" CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
dongseong.hwang@intel.com changed reviewers: + adrian.belgun@intel.com, piman@chromium.org
piman, could you review? stringify shaders like cc/output/shader.cc without logic changes. rationale: - IDE prettify code - easy to chage code without adding " and \n" everyline.
lgtm
Please fix the Windows build. LGTM https://codereview.chromium.org/2091643003/diff/1/gpu/command_buffer/service/... File gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc (right): https://codereview.chromium.org/2091643003/diff/1/gpu/command_buffer/service/... gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc:1357: ); This breaks the Windows build: gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc(1357): error C2026: string too big, trailing characters truncated Consider moving some lines from the end of cmaa_frag_s1_ to cmaa_frag_s2_. They will be concatenated at run-time. Even though CMAA is not used there because ANGLE exposes only OpenGL ES 2.0, we must make sure it builds also on Windows.
Thanks for reviewing! https://codereview.chromium.org/2091643003/diff/1/gpu/command_buffer/service/... File gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc (right): https://codereview.chromium.org/2091643003/diff/1/gpu/command_buffer/service/... gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc:1357: ); On 2016/06/24 10:47:46, adrian.belgun wrote: > This breaks the Windows build: > gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc(1357): error C2026: string > too big, trailing characters truncated > > Consider moving some lines from the end of cmaa_frag_s1_ to cmaa_frag_s2_. They > will be concatenated at run-time. > > Even though CMAA is not used there because ANGLE exposes only OpenGL ES 2.0, we > must make sure it builds also on Windows. Thanks for answering how to fix weird win build failure. Done.
Patchset #2 (id:20001) has been deleted
The CQ bit was checked by dongseong.hwang@intel.com
The patchset sent to the CQ was uploaded after l-g-t-m from adrian.belgun@intel.com, piman@chromium.org Link to the patchset: https://codereview.chromium.org/2091643003/#ps40001 (title: "fix win build")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== gpu, cmaa: Stringify shaders BUG=535198 TEST=Run a WebGL app with Chrome started with "--enable-cmaa-shaders" CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== gpu, cmaa: Stringify shaders BUG=535198 TEST=Run a WebGL app with Chrome started with "--enable-cmaa-shaders" CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== gpu, cmaa: Stringify shaders BUG=535198 TEST=Run a WebGL app with Chrome started with "--enable-cmaa-shaders" CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== gpu, cmaa: Stringify shaders BUG=535198 TEST=Run a WebGL app with Chrome started with "--enable-cmaa-shaders" CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/d81b3eaa8645508f2a4b208490ded879265b2a8d Cr-Commit-Position: refs/heads/master@{#401886} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/d81b3eaa8645508f2a4b208490ded879265b2a8d Cr-Commit-Position: refs/heads/master@{#401886} |