Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Unified Diff: third_party/WebKit/Source/platform/fonts/Font.cpp

Issue 2091633002: Make default constructor of Font class to initialize all member variables (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: 2016-06-23T10:42:43 Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/fonts/Font.cpp
diff --git a/third_party/WebKit/Source/platform/fonts/Font.cpp b/third_party/WebKit/Source/platform/fonts/Font.cpp
index 311d321c36966560472508616a5b4fe376183e11..85803885a622628aaeea13cb3c44e944ee1f5cb3 100644
--- a/third_party/WebKit/Source/platform/fonts/Font.cpp
+++ b/third_party/WebKit/Source/platform/fonts/Font.cpp
@@ -57,6 +57,8 @@ using namespace Unicode;
namespace blink {
Font::Font()
+ : m_canShapeWordByWord(0)
+ , m_shapeWordByWordComputed(0)
{
}
@@ -70,6 +72,9 @@ Font::Font(const FontDescription& fd)
Font::Font(const Font& other)
: m_fontDescription(other.m_fontDescription)
, m_fontFallbackList(other.m_fontFallbackList)
+ // TODO(yosin): We should have a comment the reason why don't we copy
+ // |m_canShapeWordByWord| and |m_shapeWordByWordComputed| from |other|,
+ // since |operator=()| copies them from |other|.
, m_canShapeWordByWord(0)
, m_shapeWordByWordComputed(0)
{
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698