Support DirectWrite with sandbox on

base/base_paths_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <windows.h>
 #include <shlobj.h>
 
 #include "base/base_paths.h"
 #include "base/files/file_path.h"
 #include "base/path_service.h"
@@ skipping 173 matching lines @@
     case base::DIR_DEFAULT_USER_QUICK_LAUNCH:
       if (!GetQuickLaunchPath(true, &cur))
         return false;
       break;
     case base::DIR_TASKBAR_PINS:
       if (!PathService::Get(base::DIR_USER_QUICK_LAUNCH, &cur))
         return false;
       cur = cur.AppendASCII("User Pinned");
       cur = cur.AppendASCII("TaskBar");
       break;
+    case base::DIR_WINDOWS_FONTS: {
+      if (win::GetVersion() < win::VERSION_VISTA)

[brettw, 2014/03/25 19:28:18]

be consistent w.r.t. base::win or just ::win. I usually fully qualify nested
namespaces for clarity, so add base:: here.

It seems like not working on XP is a significant limitation that should be
mentioned in the header. Or is it reasonable to code %WINDIR%/Fonts for XP?

[scottmg, 2014/03/25 19:45:58]

Was copy-pasta from DIR_APP_SHORTCUTS case. :/
Switched to SHGetFolderPath which works on XP. This patch will only use it on
Win7+ though.

+        return false;
+
+      base::win::ScopedCoMem<wchar_t> path_buf;
+      if (FAILED(SHGetKnownFolderPath(FOLDERID_Fonts, 0, NULL,
+                                      &path_buf)))
+        return false;
+
+      cur = FilePath(string16(path_buf));
+      break;
+    }
     default:
       return false;
   }
 
   *result = cur;
   return true;
 }
 
 }  // namespace base