Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2047)

Issue 2091603002: Invalidate fixed-pos elements & descendants on scroll w/filters that change pixels. (Closed)

Created:
4 years, 6 months ago by chrishtr
Modified:
4 years, 6 months ago
Reviewers:
Xianzhu
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Invalidate fixed-pos elements & descendants on scroll w/filters that change pixels. BUG=610287 Committed: https://crrev.com/17022a51ce7410328f50289828828bd1a385b32b Cr-Commit-Position: refs/heads/master@{#401712}

Patch Set 1 #

Patch Set 2 : none #

Patch Set 3 : none #

Patch Set 4 : none #

Patch Set 5 : none #

Patch Set 6 : none #

Total comments: 2

Patch Set 7 : none #

Messages

Total messages: 11 (5 generated)
chrishtr
4 years, 6 months ago (2016-06-23 17:15:58 UTC) #3
Xianzhu
lgtm with one comment. https://codereview.chromium.org/2091603002/diff/100001/third_party/WebKit/Source/core/frame/FrameView.cpp File third_party/WebKit/Source/core/frame/FrameView.cpp (right): https://codereview.chromium.org/2091603002/diff/100001/third_party/WebKit/Source/core/frame/FrameView.cpp#newcode1421 third_party/WebKit/Source/core/frame/FrameView.cpp:1421: TRACE_EVENT_INSTANT1( This should be also ...
4 years, 6 months ago (2016-06-23 17:43:56 UTC) #4
chrishtr
https://codereview.chromium.org/2091603002/diff/100001/third_party/WebKit/Source/core/frame/FrameView.cpp File third_party/WebKit/Source/core/frame/FrameView.cpp (right): https://codereview.chromium.org/2091603002/diff/100001/third_party/WebKit/Source/core/frame/FrameView.cpp#newcode1421 third_party/WebKit/Source/core/frame/FrameView.cpp:1421: TRACE_EVENT_INSTANT1( On 2016/06/23 at 17:43:56, Xianzhu wrote: > This ...
4 years, 6 months ago (2016-06-23 18:16:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2091603002/120001
4 years, 6 months ago (2016-06-23 18:19:45 UTC) #8
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 6 months ago (2016-06-23 20:57:06 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 20:58:52 UTC) #11
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/17022a51ce7410328f50289828828bd1a385b32b
Cr-Commit-Position: refs/heads/master@{#401712}

Powered by Google App Engine
This is Rietveld 408576698