Issue 2091583002: Fix instances where a loop 'always' exits, but also breaks, so it doesn't really exit.

Issue 2091583002: Fix instances where a loop 'always' exits, but also breaks, so it doesn't really exit. (Closed)

Created:
4 years, 6 months ago by srawlins

Modified:
4 years, 6 months ago

Reviewers:
Paul Berry, keertip, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix instances where a loop 'always' exits, but also breaks, so it doesn't really exit. BUG=https://github.com/dart-lang/sdk/issues/26755 R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/1a3f7bbcc5d426ab9280c97f0b339cfd2da8de4c

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -6 lines)			Patch
	M	pkg/analyzer/lib/src/generated/resolver.dart	View	1	2 chunks	+14 lines, -6 lines	0 comments	Download
	M	pkg/analyzer/test/generated/all_the_rest_test.dart	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download

Total messages: 6 (2 generated)

srawlins

On 2016/06/22 23:21:04, Brian Wilkerson wrote: > lgtm, though a test would be good. Gah! ...

4 years, 6 months ago (2016-06-22 23:28:29 UTC) #4

srawlins

4 years, 6 months ago (2016-06-22 23:39:12 UTC) #6

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
1a3f7bbcc5d426ab9280c97f0b339cfd2da8de4c (presubmit successful).