Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2091573004: Revert of Potential fix for flaky TSAN (Closed)

Created:
4 years, 6 months ago by msarett
Modified:
4 years, 6 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Potential fix for flaky TSAN (patchset #1 id:1 of https://codereview.chromium.org/2084243003/ ) Reason for revert: I believe I've fixed SkMatrix44::I() to be thread safe, let's test it by reverting this CL. Original issue's description: > Potential fix for flaky TSAN > > TBR=mtklein@google.com > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2084243003 > > Committed: https://skia.googlesource.com/skia/+/949999d0bbc247906995358a90c4e436e9152de2 TBR=mtklein@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/4d602144a9e7638dee25e91d64bca11d793bb5bf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tests/ColorSpaceXformTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
msarett
Created Revert of Potential fix for flaky TSAN
4 years, 6 months ago (2016-06-23 19:48:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2091573004/1
4 years, 6 months ago (2016-06-23 19:48:41 UTC) #3
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 19:48:47 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/4d602144a9e7638dee25e91d64bca11d793bb5bf

Powered by Google App Engine
This is Rietveld 408576698