Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: remoting/host/host_extension_session_manager_unittest.cc

Issue 2091553002: Expose ClientSession details to Host Extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@desktop_environment
Patch Set: Merging with ToT Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/host/host_extension_session_manager_unittest.cc
diff --git a/remoting/host/host_extension_session_manager_unittest.cc b/remoting/host/host_extension_session_manager_unittest.cc
index 32d582c5d4770cb80d8fe4958b38cacad9eb53c0..0de82ca8b6b3a4d7deefa1fb1c14d7c40092faa1 100644
--- a/remoting/host/host_extension_session_manager_unittest.cc
+++ b/remoting/host/host_extension_session_manager_unittest.cc
@@ -6,6 +6,8 @@
#include "base/strings/string_split.h"
#include "base/strings/string_util.h"
#include "remoting/codec/video_encoder.h"
+#include "remoting/host/client_session_control.h"
+#include "remoting/host/client_session_details.h"
#include "remoting/host/fake_host_extension.h"
#include "remoting/host/host_extension_session_manager.h"
#include "remoting/host/host_mock_objects.h"
@@ -37,6 +39,7 @@ class HostExtensionSessionManagerTest : public testing::Test {
// Mocks of interfaces provided by ClientSession.
MockClientSessionControl client_session_control_;
+ MockClientSessionDetails client_session_details_;
protocol::MockClientStub client_stub_;
DISALLOW_COPY_AND_ASSIGN(HostExtensionSessionManagerTest);
@@ -44,8 +47,8 @@ class HostExtensionSessionManagerTest : public testing::Test {
// Verifies that messages are handled by the correct extension.
TEST_F(HostExtensionSessionManagerTest, ExtensionMessages_MessageHandled) {
- HostExtensionSessionManager extension_manager(extensions_,
- &client_session_control_);
+ HostExtensionSessionManager extension_manager(
+ extensions_, &client_session_control_, &client_session_details_);
extension_manager.OnNegotiatedCapabilities(
&client_stub_, extension_manager.GetCapabilities());
@@ -61,8 +64,8 @@ TEST_F(HostExtensionSessionManagerTest, ExtensionMessages_MessageHandled) {
// Verifies that extension messages not handled by extensions don't result in a
// crash.
TEST_F(HostExtensionSessionManagerTest, ExtensionMessages_MessageNotHandled) {
- HostExtensionSessionManager extension_manager(extensions_,
- &client_session_control_);
+ HostExtensionSessionManager extension_manager(
+ extensions_, &client_session_control_, &client_session_details_);
extension_manager.OnNegotiatedCapabilities(
&client_stub_, extension_manager.GetCapabilities());
@@ -78,8 +81,8 @@ TEST_F(HostExtensionSessionManagerTest, ExtensionMessages_MessageNotHandled) {
// Verifies that the correct set of capabilities are reported to the client,
// based on the registered extensions.
TEST_F(HostExtensionSessionManagerTest, ExtensionCapabilities_AreReported) {
- HostExtensionSessionManager extension_manager(extensions_,
- &client_session_control_);
+ HostExtensionSessionManager extension_manager(
+ extensions_, &client_session_control_, &client_session_details_);
std::vector<std::string> reported_caps = base::SplitString(
extension_manager.GetCapabilities(), " ", base::KEEP_WHITESPACE,
@@ -94,8 +97,8 @@ TEST_F(HostExtensionSessionManagerTest, ExtensionCapabilities_AreReported) {
// Verifies that an extension is not instantiated if the client does not
// support its required capability, and that it does not receive messages.
TEST_F(HostExtensionSessionManagerTest, ExtensionCapabilities_AreChecked) {
- HostExtensionSessionManager extension_manager(extensions_,
- &client_session_control_);
+ HostExtensionSessionManager extension_manager(
+ extensions_, &client_session_control_, &client_session_details_);
extension_manager.OnNegotiatedCapabilities(&client_stub_, "cap1");
protocol::ExtensionMessage message;

Powered by Google App Engine
This is Rietveld 408576698