Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Side by Side Diff: remoting/host/security_key/gnubby_extension.cc

Issue 2091553002: Expose ClientSession details to Host Extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@desktop_environment
Patch Set: Minor fixup Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "remoting/host/security_key/gnubby_extension.h" 5 #include "remoting/host/security_key/gnubby_extension.h"
6 6
7 #include "base/memory/ptr_util.h" 7 #include "base/memory/ptr_util.h"
8 #include "remoting/host/security_key/gnubby_extension_session.h" 8 #include "remoting/host/security_key/gnubby_extension_session.h"
9 9
10 namespace { 10 namespace {
11 // TODO(joedow): Update this once clients support sending a gnubby capabililty. 11 // TODO(joedow): Update this once clients support sending a gnubby capabililty.
12 // Tracked via: crbug.com/587485 12 // Tracked via: crbug.com/587485
13 const char kCapability[] = ""; 13 const char kCapability[] = "";
14 } 14 }
15 15
16 namespace remoting { 16 namespace remoting {
17 17
18 GnubbyExtension::GnubbyExtension() {} 18 GnubbyExtension::GnubbyExtension() {}
19 19
20 GnubbyExtension::~GnubbyExtension() {} 20 GnubbyExtension::~GnubbyExtension() {}
21 21
22 std::string GnubbyExtension::capability() const { 22 std::string GnubbyExtension::capability() const {
23 return kCapability; 23 return kCapability;
24 } 24 }
25 25
26 std::unique_ptr<HostExtensionSession> GnubbyExtension::CreateExtensionSession( 26 std::unique_ptr<HostExtensionSession> GnubbyExtension::CreateExtensionSession(
27 ClientSessionControl* client_session_control, 27 ClientSessionDetails* client_session_details,
28 protocol::ClientStub* client_stub) { 28 protocol::ClientStub* client_stub) {
29 // TODO(joedow): Update this mechanism to allow for multiple sessions. The 29 // TODO(joedow): Update this mechanism to allow for multiple sessions. The
30 // extension will only send messages through the initial 30 // extension will only send messages through the initial
31 // |client_stub| with the current design. 31 // |client_stub| with the current design.
32 // TODO(joedow): Update GnubbyExtensionSession for |client_session_details|.
Sergey Ulanov 2016/06/27 19:51:30 Not sure what this TODO is about. You did update G
joedow 2016/06/27 21:07:28 Ah, this CL updated GnubbyExtension, the next CL (
32 return base::WrapUnique(new GnubbyExtensionSession(client_stub)); 33 return base::WrapUnique(new GnubbyExtensionSession(client_stub));
33 } 34 }
34 35
35 } // namespace remoting 36 } // namespace remoting
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698