[wasm] Consolidate CompileAndRunWasmModule

[wasm] Consolidate CompileAndRunWasmModule

Remove second wasm module compilation and instantiation path that
we had in CompileAndRunWasmModule and reuse the same path used
by user code.

BUG=

Committed: https://crrev.com/0b98dbcc1ed4e87b4f83630a87cae95a05cb500c
Cr-Commit-Position: refs/heads/master@{#37203}

[Mircea Trofin, 2016-06-22 20:41:22]

Description was changed from

==========
[wasm] Consolidate CompileAndRunWasmModule to reuse normal instantiation.
BUG=
==========

to

==========
[wasm] Consolidate CompileAndRunWasmModule

Remove second wasm module compilation and instantiation path that 
we had in CompileAndRunWasmModule and reuse the same path used
by user code.

BUG=
==========

[Mircea Trofin, 2016-06-22 20:41:22]

mtrofin@chromium.org changed reviewers:
+ bradnelson@chromium.org

[bradnelson, 2016-06-22 21:01:18]

The CQ bit was checked by bradnelson@chromium.org

[bradnelson, 2016-06-22 21:01:19]

lgtm

[commit-bot: I haz the power, 2016-06-22 21:01:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2091533002/1

[commit-bot: I haz the power, 2016-06-22 21:05:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-22 21:05:03]

Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/17802)

[Mircea Trofin, 2016-06-22 21:11:50]

mtrofin@chromium.org changed reviewers:
+ littledan@chromium.org

[Mircea Trofin, 2016-06-22 21:12:26]

Dan, could you please take a look - the fuzzer changes are just 
naming changes.

Thanks!

[Dan Ehrenberg, 2016-06-22 21:35:06]

lgtm

[Mircea Trofin, 2016-06-22 21:36:55]

The CQ bit was checked by mtrofin@chromium.org

[commit-bot: I haz the power, 2016-06-22 21:37:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2091533002/1

[commit-bot: I haz the power, 2016-06-22 21:38:54]

Description was changed from

==========
[wasm] Consolidate CompileAndRunWasmModule

Remove second wasm module compilation and instantiation path that 
we had in CompileAndRunWasmModule and reuse the same path used
by user code.

BUG=
==========

to

==========
[wasm] Consolidate CompileAndRunWasmModule

Remove second wasm module compilation and instantiation path that 
we had in CompileAndRunWasmModule and reuse the same path used
by user code.

BUG=
==========

[commit-bot: I haz the power, 2016-06-22 21:38:56]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-22 21:39:29]

Description was changed from

==========
[wasm] Consolidate CompileAndRunWasmModule

Remove second wasm module compilation and instantiation path that 
we had in CompileAndRunWasmModule and reuse the same path used
by user code.

BUG=
==========

to

==========
[wasm] Consolidate CompileAndRunWasmModule

Remove second wasm module compilation and instantiation path that
we had in CompileAndRunWasmModule and reuse the same path used
by user code.

BUG=

Committed: https://crrev.com/0b98dbcc1ed4e87b4f83630a87cae95a05cb500c
Cr-Commit-Position: refs/heads/master@{#37203}
==========

[commit-bot: I haz the power, 2016-06-22 21:39:30]

Patchset 1 (id:??) landed as
https://crrev.com/0b98dbcc1ed4e87b4f83630a87cae95a05cb500c
Cr-Commit-Position: refs/heads/master@{#37203}

[ahaas, 2016-06-23 13:49:18]

ahaas@chromium.org changed reviewers:
+ ahaas@chromium.org

[ahaas, 2016-06-23 13:49:19]

very nice!

https://codereview.chromium.org/2091533002/diff/1/src/wasm/wasm-module.cc
File src/wasm/wasm-module.cc (right):

https://codereview.chromium.org/2091533002/diff/1/src/wasm/wasm-module.cc#new...
src/wasm/wasm-module.cc:1045: decoding_result.error_msg.get());
Should you not return here?

[Mircea Trofin, 2016-06-23 15:04:14]

https://codereview.chromium.org/2091533002/diff/1/src/wasm/wasm-module.cc
File src/wasm/wasm-module.cc (right):

https://codereview.chromium.org/2091533002/diff/1/src/wasm/wasm-module.cc#new...
src/wasm/wasm-module.cc:1045: decoding_result.error_msg.get());
On 2016/06/23 13:49:19, ahaas wrote:
> Should you not return here?

Good catch - yes, we should.