Switch to the new go generator in the mojo tree.

Switch to the new go generator in the mojo tree. (does not affect known clients)

R=vardhan@google.com

Committed: https://chromium.googlesource.com/external/mojo/+/4596c8cdcf7b91d1a5a85bfdb750873a6878aafe

[azani, 2016-06-23 23:16:59]

Description was changed from

==========
Final shakedown for the new go generator.
==========

to

==========
Switch to the new go generator in the mojo tree. (does not affect known clients)
==========

[azani, 2016-06-23 23:17:07]

azani@chromium.org changed reviewers:
+ vardhan@google.com

[vardhan, 2016-06-24 01:36:07]

https://codereview.chromium.org/2091493002/diff/40001/mojom/generators/common...
File mojom/generators/common/cli.go (right):

https://codereview.chromium.org/2091493002/diff/40001/mojom/generators/common...
mojom/generators/common/cli.go:30: func GetCustomCliConfig(args []string,
flagSet *flag.FlagSet) GeneratorConfig {
suggestion: maybe GetCliConfigWithFlagSet?

https://codereview.chromium.org/2091493002/diff/40001/mojom/generators/go/go_...
File mojom/generators/go/go_generator.go (right):

https://codereview.chromium.org/2091493002/diff/40001/mojom/generators/go/go_...
mojom/generators/go/go_generator.go:22: flagSet.BoolVar(&noGoSrc, "no-go-src",
false, "Do not prepend the output path with go/src.")
the solution i had in mind for this was to have a flag that specified a prefix
for the output paths.  the default value of this could be "go/src", and if they
don't want anything prepended, they can just supply an empty string.  WDYT?

[vardhan, 2016-06-24 01:42:19]

lgtm

https://codereview.chromium.org/2091493002/diff/40001/mojom/generators/go/go_...
File mojom/generators/go/go_generator.go (right):

https://codereview.chromium.org/2091493002/diff/40001/mojom/generators/go/go_...
mojom/generators/go/go_generator.go:22: flagSet.BoolVar(&noGoSrc, "no-go-src",
false, "Do not prepend the output path with go/src.")
On 2016/06/24 01:36:07, vardhan wrote:
> the solution i had in mind for this was to have a flag that specified a prefix
> for the output paths.  the default value of this could be "go/src", and if
they
> don't want anything prepended, they can just supply an empty string.  WDYT?

wait, i misunderstood this flag for something else, disregard my previous
comment.

do we need this flag, given we have GeneratorConfig.OutputDir?  the user can
specify "go/src" (or whatever) to it if they want.

[azani, 2016-06-24 19:21:21]

https://codereview.chromium.org/2091493002/diff/40001/mojom/generators/common...
File mojom/generators/common/cli.go (right):

https://codereview.chromium.org/2091493002/diff/40001/mojom/generators/common...
mojom/generators/common/cli.go:30: func GetCustomCliConfig(args []string,
flagSet *flag.FlagSet) GeneratorConfig {
On 2016/06/24 01:36:07, vardhan wrote:
> suggestion: maybe GetCliConfigWithFlagSet?

Done.

https://codereview.chromium.org/2091493002/diff/40001/mojom/generators/go/go_...
File mojom/generators/go/go_generator.go (right):

https://codereview.chromium.org/2091493002/diff/40001/mojom/generators/go/go_...
mojom/generators/go/go_generator.go:22: flagSet.BoolVar(&noGoSrc, "no-go-src",
false, "Do not prepend the output path with go/src.")
On 2016/06/24 01:42:19, vardhan wrote:
> On 2016/06/24 01:36:07, vardhan wrote:
> > the solution i had in mind for this was to have a flag that specified a
prefix
> > for the output paths.  the default value of this could be "go/src", and if
> they
> > don't want anything prepended, they can just supply an empty string.  WDYT?
> 
> wait, i misunderstood this flag for something else, disregard my previous
> comment.
> 
> do we need this flag, given we have GeneratorConfig.OutputDir?  the user can
> specify "go/src" (or whatever) to it if they want.

Yes, because the output dir is the same for all the generators.

[azani, 2016-06-24 19:22:12]

Description was changed from

==========
Switch to the new go generator in the mojo tree. (does not affect known clients)
==========

to

==========
Switch to the new go generator in the mojo tree. (does not affect known clients)

R=vardhan@google.com

Committed:
https://chromium.googlesource.com/external/mojo/+/4596c8cdcf7b91d1a5a85bfdb75...
==========

[azani, 2016-06-24 19:22:13]

Committed patchset #5 (id:80001) manually as
4596c8cdcf7b91d1a5a85bfdb750873a6878aafe (presubmit successful).