Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Unified Diff: components/omnibox/browser/suggestion_answer.h

Issue 2091473003: Factor parsing "ln=" to SuggestionAnswer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/omnibox/browser/suggestion_answer.h
diff --git a/components/omnibox/browser/suggestion_answer.h b/components/omnibox/browser/suggestion_answer.h
index 8b9c04284b7153a6cbe8862855a92992444dd3a9..745e62c7b3323f40f7aaf6275887224877b037ec 100644
--- a/components/omnibox/browser/suggestion_answer.h
+++ b/components/omnibox/browser/suggestion_answer.h
@@ -147,6 +147,7 @@ class SuggestionAnswer {
const ImageLine& first_line() const { return first_line_; }
const ImageLine& second_line() const { return second_line_; }
+ int SecondLineSize() const { return second_line_size_; }
groby-ooo-7-16 2016/06/23 20:49:27 Why not simply have a LineSize() function on Image
Kevin Bailey 2016/06/23 21:49:22 Yes, I like the idea of moving it to ImageLine, bu
Kevin Bailey 2016/06/28 15:59:32 Done.
// Answer type accessors. Valid types are non-negative and defined at
// https://goto.google.com/visual_element_configuration.
@@ -165,6 +166,7 @@ class SuggestionAnswer {
ImageLine first_line_;
ImageLine second_line_;
int type_;
+ int second_line_size_;
FRIEND_TEST_ALL_PREFIXES(SuggestionAnswerTest, DifferentValuesAreUnequal);
};

Powered by Google App Engine
This is Rietveld 408576698