Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2091443002: Remove calls to deprecated MessageLoop methods in services. (Closed)

Created:
4 years, 6 months ago by fdoray
Modified:
4 years, 6 months ago
Reviewers:
jam
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove calls to deprecated MessageLoop methods in services. This CL makes the following replacements in services: Before After ---------------------------------------------------------- x.PostTask() x.task_runner()->PostTask() PostDelayedTask() PostDelayedTask() ReleaseSoon() ReleaseSoon() DeleteSoon() DeleteSoon() x->PostTask() y->task_runner()->PostTask() PostDelayedTask() PostDelayedTask() ReleaseSoon() ReleaseSoon() DeleteSoon() DeleteSoon() x.Run() RunLoop().Run() x.RunUntilIdle() RunLoop().RunUntilIdle() x->Run() RunLoop().Run() x->RunUntilIdle() RunLoop().RunUntilIdle() If |y| isn't MessageLoopForUI::current() or MessageLoopForIO::current() y.message_loop()->task_runner() y.task_runner() y->message_loop()->task_runner() y->task_runner() ---------------------------------------------------------- |x| is a base::MessageLoop(ForUI|ForIO) or a pointer to a base::MessageLoop(ForUI|ForIO). |y| is a base::Thread or a pointer to a base::Thread. This CL was generated using the MessageLoopDeprecatedMethods clang-tidy fix available on the associated bug. Only files that compile on Mac are affected. Follow-up CLs will make these replacements for other platforms. This CL doesn't change code behavior. BUG=616447 R=jam@chromium.org Committed: https://crrev.com/18f8e78847f33a3ddcd979cd2f2ca952314de02a Cr-Commit-Position: refs/heads/master@{#401386}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -12 lines) Patch
M services/shell/runner/child/test_native_main.cc View 2 chunks +2 lines, -1 line 0 comments Download
M services/shell/standalone/context.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/shell/standalone/desktop/launcher_process.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M services/shell/standalone/tracer.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M services/tracing/public/cpp/trace_provider_impl.cc View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
fdoray
Can you review this CL? Thanks.
4 years, 6 months ago (2016-06-22 15:43:02 UTC) #1
jam
lgtm
4 years, 6 months ago (2016-06-22 19:33:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2091443002/1
4 years, 6 months ago (2016-06-22 19:50:09 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-22 19:57:23 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 20:00:02 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/18f8e78847f33a3ddcd979cd2f2ca952314de02a
Cr-Commit-Position: refs/heads/master@{#401386}

Powered by Google App Engine
This is Rietveld 408576698