Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 2091393002: Gather data on Physical Web cached URL scenario (Closed)

Created:
4 years, 6 months ago by cco3
Modified:
4 years, 5 months ago
Reviewers:
nyquist, mattreynolds
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Gather data on Physical Web cached URL scenario When we try to add a URL that is in our cache, no notification should show. However, we have a flaky test that suggests this isn't the case. This change adds logging to gather additional data on what might be going wrong and marks the test as flaky. BUG=622005 Committed: https://crrev.com/90a36093a34e544b1c0a17555c6ae4ef1c5af9b0 Cr-Commit-Position: refs/heads/master@{#402233}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/UrlManagerTest.java View 1 3 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
cco3
4 years, 6 months ago (2016-06-24 18:33:35 UTC) #2
nyquist
lgtm
4 years, 6 months ago (2016-06-24 19:13:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2091393002/1
4 years, 5 months ago (2016-06-27 16:36:44 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/27237) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 5 months ago (2016-06-27 16:39:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2091393002/20001
4 years, 5 months ago (2016-06-27 17:07:45 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-27 18:30:25 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 18:31:37 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/90a36093a34e544b1c0a17555c6ae4ef1c5af9b0
Cr-Commit-Position: refs/heads/master@{#402233}

Powered by Google App Engine
This is Rietveld 408576698