Mark focus-controller-recursion-crash.html as flaky

Mark focus-controller-recursion-crash.html as flaky

BUG=600008
Committed: https://crrev.com/1c2c10a176436c4be12b4a7f02741656415c98c4
Cr-Commit-Position: refs/heads/master@{#401934}

[Elly Fong-Jones, 2016-06-24 18:06:27]

Description was changed from

==========
Mark focus-controller-recursion-crash.html as flaky

BUG=
==========

to

==========
Mark focus-controller-recursion-crash.html as flaky

BUG=
==========

[Elly Fong-Jones, 2016-06-24 18:06:27]

ellyjones@chromium.org changed reviewers:
+ dpranke@chromium.org

[Elly Fong-Jones, 2016-06-24 18:06:34]

dpranke: ptal? :)

[Dirk Pranke, 2016-06-24 18:08:45]

https://codereview.chromium.org/2091363002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/TestExpectations (right):

https://codereview.chromium.org/2091363002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/TestExpectations:49: crbug.com/600008
fast/dom/shadow/focus-controller-recursion-crash.html [ Failure Pass
NeedsManualRebaseline ]
The presence of multiple entries is enough to indicate that the bug is flaky.

I'd delete the comment, and re-open bug 600008 and dup 622892 into it with a
comment that things are flaky (and also that bugs shouldn't be closed while
there are still manualrebaseline entries).

[Dirk Pranke, 2016-06-24 18:09:39]

but, lgtm w/ edits made; otherwise, this was right.

though that shouldn't be producing failures if it's marked as
NeedsManualRebaseline, and add the BUG= to the CL description.

[Elly Fong-Jones, 2016-06-24 18:12:24]

Description was changed from

==========
Mark focus-controller-recursion-crash.html as flaky

BUG=
==========

to

==========
Mark focus-controller-recursion-crash.html as flaky

BUG=600008
==========

[Dirk Pranke, 2016-06-24 18:12:35]

On 2016/06/24 18:09:39, Dirk Pranke wrote:
> but, lgtm w/ edits made; otherwise, this was right.
> 
> though that shouldn't be producing failures if it's marked as
> NeedsManualRebaseline, and add the BUG= to the CL description.

and, actually, this should be [ NeedsManualRebaseline Timeout ], not [ Pass Fail
... ]. That's why you're getting
errors, NeedsManualRebaseline suppresses Pass/Fail errors, but not timeouts.

[Dirk Pranke, 2016-06-24 18:15:47]

lgtm, thanks!

[Elly Fong-Jones, 2016-06-24 18:16:07]

The CQ bit was checked by ellyjones@chromium.org

[commit-bot: I haz the power, 2016-06-24 18:16:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-24 19:37:52]

Description was changed from

==========
Mark focus-controller-recursion-crash.html as flaky

BUG=600008
==========

to

==========
Mark focus-controller-recursion-crash.html as flaky

BUG=600008
==========

[commit-bot: I haz the power, 2016-06-24 19:37:52]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-24 19:39:30]

Description was changed from

==========
Mark focus-controller-recursion-crash.html as flaky

BUG=600008
==========

to

==========
Mark focus-controller-recursion-crash.html as flaky

BUG=600008

Committed: https://crrev.com/1c2c10a176436c4be12b4a7f02741656415c98c4
Cr-Commit-Position: refs/heads/master@{#401934}
==========

[commit-bot: I haz the power, 2016-06-24 19:39:31]

Patchset 3 (id:??) landed as
https://crrev.com/1c2c10a176436c4be12b4a7f02741656415c98c4
Cr-Commit-Position: refs/heads/master@{#401934}