chrome/browser/page_load_metrics/page_load_metrics_initialize.cc - Issue 2091353002: Generalize the reload PLMO to support other transition types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

Issue 2091353002: Generalize the reload PLMO to support other transition types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

diff --git a/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc b/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

index 2bba4bd53b6daaa01b68af1cc4ff6bbd8d4afd8f..16b00283a96a6a1decdd1e4e86037e19885db90f 100644

--- a/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

+++ b/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

@@ -12,7 +12,6 @@

#include "chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h"

#include "chrome/browser/page_load_metrics/observers/google_captcha_observer.h"

#include "chrome/browser/page_load_metrics/observers/https_engagement_page_load_metrics_observer.h"

-#include "chrome/browser/page_load_metrics/observers/reload_page_load_metrics_observer.h"

#include "chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.h"

#include "chrome/browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.h"

#include "chrome/browser/prerender/prerender_contents.h"

@@ -49,7 +48,6 @@ void PageLoadMetricsEmbedder::RegisterObservers(

base::WrapUnique(new ServiceWorkerPageLoadMetricsObserver()));

tracker->AddObserver(

base::WrapUnique(new HttpsEngagementPageLoadMetricsObserver()));

- tracker->AddObserver(base::WrapUnique(new ReloadPageLoadMetricsObserver()));

}

bool PageLoadMetricsEmbedder::IsPrerendering(

« no previous file with comments | « chrome/browser/page_load_metrics/observers/reload_page_load_metrics_observer.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »