Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4916)

Unified Diff: chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc

Issue 2091353002: Generalize the reload PLMO to support other transition types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add abort unit tests Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc
diff --git a/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc b/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc
index 90854b00129b1d5dadec1ef005c7b9d4d12c2ae3..5710c995acd0a1389bb92a931ac4091181460072 100644
--- a/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc
+++ b/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc
@@ -9,6 +9,9 @@
#include "base/macros.h"
#include "base/memory/ptr_util.h"
#include "components/page_load_metrics/common/page_load_metrics_messages.h"
+#include "content/public/browser/navigation_entry.h"
+#include "content/public/browser/web_contents.h"
+#include "content/public/test/web_contents_tester.h"
#include "third_party/WebKit/public/web/WebInputEvent.h"
namespace page_load_metrics {
@@ -135,4 +138,15 @@ PageLoadMetricsObserverTestHarness::GetPageLoadExtraInfoForCommittedLoad() {
return observer_->GetPageLoadExtraInfoForCommittedLoad();
}
+void PageLoadMetricsObserverTestHarness::NavigateWithPageTransitionAndCommit(
+ const GURL& url,
+ ui::PageTransition transition) {
+ controller().LoadURL(url, content::Referrer(), transition, std::string());
+ int pending_id = controller().GetPendingEntry()->GetUniqueID();
+ const bool did_create_new_entry = true;
+ content::WebContentsTester::For(web_contents())
+ ->TestDidNavigate(web_contents()->GetMainFrame(), 1, pending_id,
+ did_create_new_entry, url, transition);
+}
+
} // namespace page_load_metrics

Powered by Google App Engine
This is Rietveld 408576698