tools/metrics/histograms/histograms.xml - Issue 2091353002: Generalize the reload PLMO to support other transition types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 2091353002: Generalize the reload PLMO to support other transition types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add abort unit tests Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 5e0ad4ea615425c4fac55403586d13378614c966..2a534db847570d6d43ca1c847cc231303db51b87 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -97010,18 +97010,38 @@ To add a new entry, add it with any value and run test to compute valid value.

<histogram_suffixes name="PageLoadMetricsClients.Reload" separator="."

ordering="prefix">

+ <obsolete>

+ Deprecated in favor of LoadType.Reload.

+ </obsolete>

<suffix name="Clients.Reload"

label="PageLoadMetrics from a page that is reloaded"/>

<affected-histogram

name="PageLoad.PaintTiming.NavigationToFirstContentfulPaint"/>

</histogram_suffixes>

-<histogram_suffixes name="PageLoadMetricsClients.Reload.UserGesture"

- separator=".">

+<histogram_suffixes name="PageLoadMetricsLoadType" separator=".">

+ <suffix name="LoadType.Reload" label="Restricted to reloaded pages."/>

+ <suffix name="LoadType.ForwardBackNavigation"

+ label="Restricted to forward/back navigations."/>

+ <suffix name="LoadType.NewNavigation"

+ label="Restricted to new navigations (link clicks, URLs typed into the

+ URL box, etc)."/>

+ <affected-histogram

+ name="PageLoad.PaintTiming.NavigationToFirstContentfulPaint"/>

+</histogram_suffixes>

+<histogram_suffixes name="PageLoadMetricsUserGesture" separator=".">

<suffix name="UserGesture"

- label="PageLoadMetrics from a page that is reloaded by a user gesture"/>

+ label="Restricted to pages loaded via a user gesture."/>

+ <affected-histogram

+ name="PageLoad.Clients.Reload.PaintTiming.NavigationToFirstContentfulPaint">

+ <obsolete>

+ Deprecated in favor of

+ PageLoad.PaintTiming.NavigationToFirstContentfulPaint.LoadType.Reload.

+ </obsolete>

+ </affected-histogram>

<affected-histogram

- name="PageLoad.Clients.Reload.PaintTiming.NavigationToFirstContentfulPaint"/>

+ name="PageLoad.PaintTiming.NavigationToFirstContentfulPaint.LoadType.Reload"/>

</histogram_suffixes>

<histogram_suffixes name="PageLoadType">

« chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc ('K') | « chrome/chrome_browser.gypi ('k') | no next file » | no next file with comments »