chrome/browser/page_load_metrics/observers/reload_page_load_metrics_observer.cc - Issue 2091353002: Generalize the reload PLMO to support other transition types.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/page_load_metrics/observers/reload_page_load_metrics_observer.cc

Issue 2091353002: Generalize the reload PLMO to support other transition types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add abort unit tests Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc ('K') | « chrome/browser/page_load_metrics/observers/reload_page_load_metrics_observer.h ('k') | chrome/browser/page_load_metrics/page_load_metrics_initialize.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
	(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.

4

5 #include "chrome/browser/page_load_metrics/observers/reload_page_load_metrics_ob server.h"

6

7 #include "chrome/browser/page_load_metrics/observers/core_page_load_metrics_obse rver.h"

8 #include "components/page_load_metrics/browser/page_load_metrics_util.h"

9 #include "ui/base/page_transition_types.h"

10

11 namespace chrome {

12

13 namespace {

14

15 const char kHistogramFirstContentfulPaintReload[] =

16 "PageLoad.Clients.Reload.PaintTiming.NavigationToFirstContentfulPaint";

17 const char kHistogramFirstContentfulPaintReloadByGesture[] =

18 "PageLoad.Clients.Reload.PaintTiming.NavigationToFirstContentfulPaint."

19 "UserGesture";

20

21 } // namespace

22

23 ReloadPageLoadMetricsObserver::ReloadPageLoadMetricsObserver()

24 : page_transition_was_reload_(false), initiated_by_user_gesture_(false) {}

25

26 void ReloadPageLoadMetricsObserver::OnCommit(

27 content::NavigationHandle* navigation_handle) {

28 page_transition_was_reload_ = ui::PageTransitionCoreTypeIs(

29 navigation_handle->GetPageTransition(), ui::PAGE_TRANSITION_RELOAD);

30 initiated_by_user_gesture_ = navigation_handle->HasUserGesture();

31 }

32

33 void ReloadPageLoadMetricsObserver::OnFirstContentfulPaint(

34 const page_load_metrics::PageLoadTiming& timing,

35 const page_load_metrics::PageLoadExtraInfo& extra_info) {

36 if (!page_transition_was_reload_ \|\|

37 !WasStartedInForegroundEventInForeground(timing.first_contentful_paint,

38 extra_info)) {

39 return;

40 }

41

42 PAGE_LOAD_HISTOGRAM(kHistogramFirstContentfulPaintReload,

43 timing.first_contentful_paint);

44 if (initiated_by_user_gesture_) {

45 PAGE_LOAD_HISTOGRAM(kHistogramFirstContentfulPaintReloadByGesture,

46 timing.first_contentful_paint);

47 }

48 }

49

50 } // namespace chrome

OLD	NEW