Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Side by Side Diff: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h

Issue 2091353002: Generalize the reload PLMO to support other transition types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add abort unit tests Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_CORE_PAGE_LOAD_METRICS_OBSERV ER_H_ 5 #ifndef CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_CORE_PAGE_LOAD_METRICS_OBSERV ER_H_
6 #define CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_CORE_PAGE_LOAD_METRICS_OBSERV ER_H_ 6 #define CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_CORE_PAGE_LOAD_METRICS_OBSERV ER_H_
7 7
8 #include "components/page_load_metrics/browser/page_load_metrics_observer.h" 8 #include "components/page_load_metrics/browser/page_load_metrics_observer.h"
9 9
10 namespace internal { 10 namespace internal {
(...skipping 14 matching lines...) Expand all
25 extern const char kHistogramParseDuration[]; 25 extern const char kHistogramParseDuration[];
26 extern const char kHistogramParseBlockedOnScriptLoad[]; 26 extern const char kHistogramParseBlockedOnScriptLoad[];
27 27
28 extern const char kBackgroundHistogramCommit[]; 28 extern const char kBackgroundHistogramCommit[];
29 extern const char kBackgroundHistogramFirstLayout[]; 29 extern const char kBackgroundHistogramFirstLayout[];
30 extern const char kBackgroundHistogramFirstTextPaint[]; 30 extern const char kBackgroundHistogramFirstTextPaint[];
31 extern const char kBackgroundHistogramDomContentLoaded[]; 31 extern const char kBackgroundHistogramDomContentLoaded[];
32 extern const char kBackgroundHistogramLoad[]; 32 extern const char kBackgroundHistogramLoad[];
33 extern const char kBackgroundHistogramFirstPaint[]; 33 extern const char kBackgroundHistogramFirstPaint[];
34 34
35 extern const char kHistogramLoadTypeFirstContentfulPaintReload[];
36 extern const char kHistogramLoadTypeFirstContentfulPaintForwardBack[];
37 extern const char kHistogramLoadTypeFirstContentfulPaintNewNavigation[];
38
35 extern const char kHistogramBackgroundBeforePaint[]; 39 extern const char kHistogramBackgroundBeforePaint[];
36 extern const char kHistogramFailedProvisionalLoad[]; 40 extern const char kHistogramFailedProvisionalLoad[];
37 41
38 extern const char kRapporMetricsNameCoarseTiming[]; 42 extern const char kRapporMetricsNameCoarseTiming[];
39 43
40 } // namespace internal 44 } // namespace internal
41 45
42 // Observer responsible for recording 'core' page load metrics. Core metrics are 46 // Observer responsible for recording 'core' page load metrics. Core metrics are
43 // maintained by loading-dev team, typically the metrics under 47 // maintained by loading-dev team, typically the metrics under
44 // PageLoad.(Document|Paint|Parse)Timing.*. 48 // PageLoad.(Document|Paint|Parse)Timing.*.
45 class CorePageLoadMetricsObserver 49 class CorePageLoadMetricsObserver
46 : public page_load_metrics::PageLoadMetricsObserver { 50 : public page_load_metrics::PageLoadMetricsObserver {
47 public: 51 public:
48 CorePageLoadMetricsObserver(); 52 CorePageLoadMetricsObserver();
49 ~CorePageLoadMetricsObserver() override; 53 ~CorePageLoadMetricsObserver() override;
50 54
51 // page_load_metrics::PageLoadMetricsObserver: 55 // page_load_metrics::PageLoadMetricsObserver:
56 void OnCommit(content::NavigationHandle* navigation_handle) override;
52 void OnDomContentLoadedEventStart( 57 void OnDomContentLoadedEventStart(
53 const page_load_metrics::PageLoadTiming& timing, 58 const page_load_metrics::PageLoadTiming& timing,
54 const page_load_metrics::PageLoadExtraInfo& extra_info) override; 59 const page_load_metrics::PageLoadExtraInfo& extra_info) override;
55 void OnLoadEventStart( 60 void OnLoadEventStart(
56 const page_load_metrics::PageLoadTiming& timing, 61 const page_load_metrics::PageLoadTiming& timing,
57 const page_load_metrics::PageLoadExtraInfo& extra_info) override; 62 const page_load_metrics::PageLoadExtraInfo& extra_info) override;
58 void OnFirstLayout( 63 void OnFirstLayout(
59 const page_load_metrics::PageLoadTiming& timing, 64 const page_load_metrics::PageLoadTiming& timing,
60 const page_load_metrics::PageLoadExtraInfo& extra_info) override; 65 const page_load_metrics::PageLoadExtraInfo& extra_info) override;
61 void OnFirstPaint( 66 void OnFirstPaint(
(...skipping 29 matching lines...) Expand all
91 FailedProvisionalLoadInfo(); 96 FailedProvisionalLoadInfo();
92 ~FailedProvisionalLoadInfo(); 97 ~FailedProvisionalLoadInfo();
93 }; 98 };
94 99
95 void RecordTimingHistograms(const page_load_metrics::PageLoadTiming& timing, 100 void RecordTimingHistograms(const page_load_metrics::PageLoadTiming& timing,
96 const page_load_metrics::PageLoadExtraInfo& info); 101 const page_load_metrics::PageLoadExtraInfo& info);
97 void RecordRappor(const page_load_metrics::PageLoadTiming& timing, 102 void RecordRappor(const page_load_metrics::PageLoadTiming& timing,
98 const page_load_metrics::PageLoadExtraInfo& info); 103 const page_load_metrics::PageLoadExtraInfo& info);
99 104
100 FailedProvisionalLoadInfo failed_provisional_load_info_; 105 FailedProvisionalLoadInfo failed_provisional_load_info_;
106 ui::PageTransition transition_;
107 bool initiated_by_user_gesture_;
101 108
102 DISALLOW_COPY_AND_ASSIGN(CorePageLoadMetricsObserver); 109 DISALLOW_COPY_AND_ASSIGN(CorePageLoadMetricsObserver);
103 }; 110 };
104 111
105 #endif // CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_CORE_PAGE_LOAD_METRICS_OBS ERVER_H_ 112 #endif // CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_CORE_PAGE_LOAD_METRICS_OBS ERVER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698