Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3487)

Unified Diff: chrome/browser/ui/views/tabs/tab_strip.cc

Issue 2091343002: Changes pinned tab throbbing indicator to a static image (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: feedback Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/tabs/tab.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/tabs/tab_strip.cc
diff --git a/chrome/browser/ui/views/tabs/tab_strip.cc b/chrome/browser/ui/views/tabs/tab_strip.cc
index 9885e13b275da48b303a8bbd89d86612c490e39a..1cc763c42c91acc154092efe7e71f7b267e3a152 100644
--- a/chrome/browser/ui/views/tabs/tab_strip.cc
+++ b/chrome/browser/ui/views/tabs/tab_strip.cc
@@ -1020,7 +1020,8 @@ void TabStrip::SetSelection(const ui::ListSelectionModel& old_selection,
// Fire accessibility events that reflect the changes to selection, and
// stop the pinned tab title animation on tabs no longer selected.
for (size_t i = 0; i < no_longer_selected.size(); ++i) {
- tab_at(no_longer_selected[i])->StopPinnedTabTitleAnimation();
+ tab_at(no_longer_selected[i])
+ ->SetPinnedTabTitleChangedIndicatorVisible(false);
tab_at(no_longer_selected[i])->NotifyAccessibilityEvent(
ui::AX_EVENT_SELECTION_REMOVE, true);
}
@@ -1035,7 +1036,7 @@ void TabStrip::SetSelection(const ui::ListSelectionModel& old_selection,
void TabStrip::TabTitleChangedNotLoading(int model_index) {
Tab* tab = tab_at(model_index);
if (tab->data().pinned && !tab->IsActive())
- tab->StartPinnedTabTitleAnimation();
+ tab->SetPinnedTabTitleChangedIndicatorVisible(true);
}
int TabStrip::GetModelIndexOfTab(const Tab* tab) const {
« no previous file with comments | « chrome/browser/ui/views/tabs/tab.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698