Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 2091333002: DevTools: Added "none" to list of suggestions for CSS text-decoration (Closed)

Created:
4 years, 6 months ago by flandy
Modified:
4 years, 6 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Added "none" to list of possible values for CSS text-decoration property suggestion. BUG=616437 Committed: https://crrev.com/06fd248705d56cbe911cdc20070d14d8b61f97f6 Cr-Commit-Position: refs/heads/master@{#401992}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/sdk/CSSMetadata.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
flandy
Hi, it looks like the extension of text-decoration to a shorthand for CSS3 is still ...
4 years, 6 months ago (2016-06-24 15:38:21 UTC) #4
dgozman
lgtm
4 years, 6 months ago (2016-06-24 19:07:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2091333002/1
4 years, 6 months ago (2016-06-24 19:15:35 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-24 22:06:06 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-24 22:09:09 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/06fd248705d56cbe911cdc20070d14d8b61f97f6
Cr-Commit-Position: refs/heads/master@{#401992}

Powered by Google App Engine
This is Rietveld 408576698