Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1127)

Unified Diff: chrome/browser/ui/webui/ntp/ntp_user_data_logger_unittest.cc

Issue 2091323002: Kill NewTabPage.NumberOfMouseOvers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add additional file to sync. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/ntp/ntp_user_data_logger.cc ('k') | chrome/common/search/ntp_logging_events.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/ntp/ntp_user_data_logger_unittest.cc
diff --git a/chrome/browser/ui/webui/ntp/ntp_user_data_logger_unittest.cc b/chrome/browser/ui/webui/ntp/ntp_user_data_logger_unittest.cc
index 98d658dc0ff1ead43038f8566ebe84b84612ea95..81b7036b46a2a7fe629816659d7e2eec37c0b86a 100644
--- a/chrome/browser/ui/webui/ntp/ntp_user_data_logger_unittest.cc
+++ b/chrome/browser/ui/webui/ntp/ntp_user_data_logger_unittest.cc
@@ -43,17 +43,11 @@ class NTPUserDataLoggerTest : public testing::Test {
TEST_F(NTPUserDataLoggerTest, TestLogging) {
base::StatisticsRecorder::Initialize();
- // Ensure empty statistics.
- EXPECT_EQ(0, GetTotalCount("NewTabPage.NumberOfMouseOvers"));
- EXPECT_EQ(0, GetBinCount("NewTabPage.NumberOfMouseOvers", 0));
-
// Enusure non-zero statistics.
TestNTPUserDataLogger logger;
base::TimeDelta delta = base::TimeDelta::FromMilliseconds(0);
- for (int i = 0; i < 20; ++i)
- logger.LogEvent(NTP_MOUSEOVER, delta);
for (int i = 0; i < 8; ++i)
logger.LogEvent(NTP_TILE, delta);
for (int i = 0; i < 4; ++i)
@@ -70,9 +64,6 @@ TEST_F(NTPUserDataLoggerTest, TestLogging) {
logger.EmitNtpStatistics();
- EXPECT_EQ(1, GetTotalCount("NewTabPage.NumberOfMouseOvers"));
- EXPECT_EQ(0, GetBinCount("NewTabPage.NumberOfMouseOvers", 0));
- EXPECT_EQ(1, GetBinCount("NewTabPage.NumberOfMouseOvers", 20));
EXPECT_EQ(1, GetTotalCount("NewTabPage.NumberOfTiles"));
EXPECT_EQ(1, GetBinCount("NewTabPage.NumberOfTiles", 8));
EXPECT_EQ(1, GetTotalCount("NewTabPage.NumberOfThumbnailTiles"));
@@ -92,9 +83,6 @@ TEST_F(NTPUserDataLoggerTest, TestLogging) {
// Statistics should be reset to 0, so we should not log anything else.
logger.EmitNtpStatistics();
- EXPECT_EQ(2, GetTotalCount("NewTabPage.NumberOfMouseOvers"));
- EXPECT_EQ(1, GetBinCount("NewTabPage.NumberOfMouseOvers", 0));
- EXPECT_EQ(1, GetBinCount("NewTabPage.NumberOfMouseOvers", 20));
EXPECT_EQ(1, GetTotalCount("NewTabPage.NumberOfTiles"));
EXPECT_EQ(1, GetTotalCount("NewTabPage.NumberOfThumbnailTiles"));
EXPECT_EQ(1, GetTotalCount("NewTabPage.NumberOfThumbnailErrors"));
« no previous file with comments | « chrome/browser/ui/webui/ntp/ntp_user_data_logger.cc ('k') | chrome/common/search/ntp_logging_events.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698