Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1097)

Unified Diff: chrome/browser/resources/local_ntp/most_visited_single.js

Issue 2091323002: Kill NewTabPage.NumberOfMouseOvers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add additional file to sync. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/local_ntp/most_visited_util.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/local_ntp/most_visited_single.js
diff --git a/chrome/browser/resources/local_ntp/most_visited_single.js b/chrome/browser/resources/local_ntp/most_visited_single.js
index 70f9dcbb12cee39712bf5506113dfb00386e5329..c10cd549ecbbd5f46ef1129b46a909e8626cb9c9 100644
--- a/chrome/browser/resources/local_ntp/most_visited_single.js
+++ b/chrome/browser/resources/local_ntp/most_visited_single.js
@@ -25,22 +25,9 @@ var LOG_TYPE = {
NTP_TILE: 2,
// The tile uses a local thumbnail image.
NTP_THUMBNAIL_TILE: 3,
- // Used when no thumbnail is specified and a gray tile with the domain is used
- // as the main tile. Unused here.
- NTP_GRAY_TILE: 4,
- // The visuals of that tile are handled externally by the page itself.
- // Unused here.
- NTP_EXTERNAL_TILE: 5,
// There was an error in loading both the thumbnail image and the fallback
// (if it was provided), resulting in a gray tile.
NTP_THUMBNAIL_ERROR: 6,
- // Used a gray tile with the domain as the fallback for a failed thumbnail.
- // Unused here.
- NTP_GRAY_TILE_FALLBACK: 7,
- // The visuals of that tile's fallback are handled externally. Unused here.
- NTP_EXTERNAL_TILE_FALLBACK: 8,
- // The user moused over an NTP tile.
- NTP_MOUSEOVER: 9,
// A NTP Tile has finished loading (successfully or failing).
NTP_TILE_LOADED: 10,
};
@@ -459,10 +446,6 @@ var renderTile = function(data) {
}
}
});
- // TODO(fserb): remove this or at least change to mouseenter.
- tile.addEventListener('mouseover', function() {
- logEvent(LOG_TYPE.NTP_MOUSEOVER);
- });
var title = tile.querySelector('.mv-title');
title.innerText = data.title;
« no previous file with comments | « no previous file | chrome/browser/resources/local_ntp/most_visited_util.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698