Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4853)

Unified Diff: chrome/browser/ui/webui/ntp/ntp_user_data_logger_unittest.cc

Issue 2091323002: Kill NewTabPage.NumberOfMouseOvers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/ntp/ntp_user_data_logger_unittest.cc
diff --git a/chrome/browser/ui/webui/ntp/ntp_user_data_logger_unittest.cc b/chrome/browser/ui/webui/ntp/ntp_user_data_logger_unittest.cc
index 8f9b9bcafd7c03085b2d8edcb845e6c770f86d8b..2a6fd9e54fbd5af80eb83604c4a1fb843fe26fd1 100644
--- a/chrome/browser/ui/webui/ntp/ntp_user_data_logger_unittest.cc
+++ b/chrome/browser/ui/webui/ntp/ntp_user_data_logger_unittest.cc
@@ -43,10 +43,6 @@ class NTPUserDataLoggerTest : public testing::Test {
TEST_F(NTPUserDataLoggerTest, TestLogging) {
base::StatisticsRecorder::Initialize();
- // Ensure empty statistics.
- EXPECT_EQ(0, GetTotalCount("NewTabPage.NumberOfMouseOvers"));
- EXPECT_EQ(0, GetBinCount("NewTabPage.NumberOfMouseOvers", 0));
-
// Enusure non-zero statistics.
TestNTPUserDataLogger logger;
@@ -70,9 +66,6 @@ TEST_F(NTPUserDataLoggerTest, TestLogging) {
logger.EmitNtpStatistics();
- EXPECT_EQ(1, GetTotalCount("NewTabPage.NumberOfMouseOvers"));
- EXPECT_EQ(0, GetBinCount("NewTabPage.NumberOfMouseOvers", 0));
- EXPECT_EQ(1, GetBinCount("NewTabPage.NumberOfMouseOvers", 20));
EXPECT_EQ(1, GetTotalCount("NewTabPage.NumberOfTiles"));
EXPECT_EQ(1, GetBinCount("NewTabPage.NumberOfTiles", 8));
EXPECT_EQ(1, GetTotalCount("NewTabPage.NumberOfThumbnailTiles"));
@@ -92,9 +85,6 @@ TEST_F(NTPUserDataLoggerTest, TestLogging) {
// Statistics should be reset to 0, so we should not log anything else.
logger.EmitNtpStatistics();
- EXPECT_EQ(2, GetTotalCount("NewTabPage.NumberOfMouseOvers"));
- EXPECT_EQ(1, GetBinCount("NewTabPage.NumberOfMouseOvers", 0));
- EXPECT_EQ(1, GetBinCount("NewTabPage.NumberOfMouseOvers", 20));
EXPECT_EQ(1, GetTotalCount("NewTabPage.NumberOfTiles"));
EXPECT_EQ(1, GetTotalCount("NewTabPage.NumberOfThumbnailTiles"));
EXPECT_EQ(1, GetTotalCount("NewTabPage.NumberOfThumbnailErrors"));

Powered by Google App Engine
This is Rietveld 408576698