Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: chrome/common/ntp_logging_events.h

Issue 2091323002: Kill NewTabPage.NumberOfMouseOvers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Deprecate histogram. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_COMMON_NTP_LOGGING_EVENTS_H_ 5 #ifndef CHROME_COMMON_NTP_LOGGING_EVENTS_H_
6 #define CHROME_COMMON_NTP_LOGGING_EVENTS_H_ 6 #define CHROME_COMMON_NTP_LOGGING_EVENTS_H_
7 7
8 // The different types of events that are logged from the NTP. This enum is used 8 // The different types of events that are logged from the NTP. This enum is used
9 // to transfer information from the NTP javascript to the renderer and is not 9 // to transfer information from the NTP javascript to the renderer and is not
10 // used as a UMA enum histogram's logged value. 10 // used as a UMA enum histogram's logged value.
11 // Note: Keep in sync with browser/resources/local_ntp/most_visited_util.js 11 // Note: Keep in sync with browser/resources/local_ntp/most_visited_util.js
Marc Treib 2016/07/05 08:07:31 Could you add "most_visited_single.js"?
sfiera 2016/07/05 18:24:40 Done.
12 enum NTPLoggingEventType { 12 enum NTPLoggingEventType {
13 // The suggestion is coming from the server. 13 // The suggestion is coming from the server.
14 NTP_SERVER_SIDE_SUGGESTION = 0, 14 NTP_SERVER_SIDE_SUGGESTION = 0,
15 15
16 // The suggestion is coming from the client. 16 // The suggestion is coming from the client.
17 NTP_CLIENT_SIDE_SUGGESTION = 1, 17 NTP_CLIENT_SIDE_SUGGESTION = 1,
18 18
19 // Indicates a tile was rendered, no matter if it's a thumbnail, a gray tile 19 // Indicates a tile was rendered, no matter if it's a thumbnail, a gray tile
20 // or an external tile. 20 // or an external tile.
21 NTP_TILE = 2, 21 NTP_TILE = 2,
(...skipping 11 matching lines...) Expand all
33 // There was an error in loading both the thumbnail image and the fallback 33 // There was an error in loading both the thumbnail image and the fallback
34 // (if it was provided), resulting in a grey tile. 34 // (if it was provided), resulting in a grey tile.
35 NTP_THUMBNAIL_ERROR = 6, 35 NTP_THUMBNAIL_ERROR = 6,
36 36
37 // Used a gray tile with the domain as the fallback for a failed thumbnail. 37 // Used a gray tile with the domain as the fallback for a failed thumbnail.
38 NTP_GRAY_TILE_FALLBACK = 7, 38 NTP_GRAY_TILE_FALLBACK = 7,
39 39
40 // The visuals of that tile's fallback are handled externally. 40 // The visuals of that tile's fallback are handled externally.
41 NTP_EXTERNAL_TILE_FALLBACK = 8, 41 NTP_EXTERNAL_TILE_FALLBACK = 8,
42 42
43 // The user moused over an NTP tile or title. 43 // Deleted: NTP_MOUSEOVER = 9
Marc Treib 2016/07/05 08:07:31 Since this is not used as UMA, we could actually r
sfiera 2016/07/05 18:24:40 I'd just as soon leave it as is. We'll probably ma
44 NTP_MOUSEOVER = 9,
45 44
46 // A NTP Tile has finished loading (successfully or failing). 45 // A NTP Tile has finished loading (successfully or failing).
47 NTP_TILE_LOADED = 10, 46 NTP_TILE_LOADED = 10,
48 47
49 NTP_EVENT_TYPE_LAST = NTP_TILE_LOADED 48 NTP_EVENT_TYPE_LAST = NTP_TILE_LOADED
50 }; 49 };
51 50
52 #endif // CHROME_COMMON_NTP_LOGGING_EVENTS_H_ 51 #endif // CHROME_COMMON_NTP_LOGGING_EVENTS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698