Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Side by Side Diff: chrome/browser/ui/webui/metrics_handler.cc

Issue 2091323002: Kill NewTabPage.NumberOfMouseOvers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add additional file to sync. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/metrics_handler.h" 5 #include "chrome/browser/ui/webui/metrics_handler.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/bind_helpers.h" 8 #include "base/bind_helpers.h"
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/metrics/histogram.h" 10 #include "base/metrics/histogram.h"
(...skipping 18 matching lines...) Expand all
29 web_ui()->RegisterMessageCallback( 29 web_ui()->RegisterMessageCallback(
30 "metricsHandler:recordAction", 30 "metricsHandler:recordAction",
31 base::Bind(&MetricsHandler::HandleRecordAction, base::Unretained(this))); 31 base::Bind(&MetricsHandler::HandleRecordAction, base::Unretained(this)));
32 web_ui()->RegisterMessageCallback( 32 web_ui()->RegisterMessageCallback(
33 "metricsHandler:recordInHistogram", 33 "metricsHandler:recordInHistogram",
34 base::Bind(&MetricsHandler::HandleRecordInHistogram, 34 base::Bind(&MetricsHandler::HandleRecordInHistogram,
35 base::Unretained(this))); 35 base::Unretained(this)));
36 web_ui()->RegisterMessageCallback( 36 web_ui()->RegisterMessageCallback(
37 "metricsHandler:logEventTime", 37 "metricsHandler:logEventTime",
38 base::Bind(&MetricsHandler::HandleLogEventTime, base::Unretained(this))); 38 base::Bind(&MetricsHandler::HandleLogEventTime, base::Unretained(this)));
39 web_ui()->RegisterMessageCallback(
40 "metricsHandler:logMouseover",
41 base::Bind(&MetricsHandler::HandleLogMouseover, base::Unretained(this)));
42 } 39 }
43 40
44 void MetricsHandler::HandleRecordAction(const base::ListValue* args) { 41 void MetricsHandler::HandleRecordAction(const base::ListValue* args) {
45 std::string string_action = base::UTF16ToUTF8(ExtractStringValue(args)); 42 std::string string_action = base::UTF16ToUTF8(ExtractStringValue(args));
46 content::RecordComputedAction(string_action); 43 content::RecordComputedAction(string_action);
47 } 44 }
48 45
49 void MetricsHandler::HandleRecordInHistogram(const base::ListValue* args) { 46 void MetricsHandler::HandleRecordInHistogram(const base::ListValue* args) {
50 std::string histogram_name; 47 std::string histogram_name;
51 double value; 48 double value;
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
99 UMA_HISTOGRAM_TIMES("Tab.NewTabDOMContentLoaded", duration); 96 UMA_HISTOGRAM_TIMES("Tab.NewTabDOMContentLoaded", duration);
100 } else if (event_name == "Tab.NewTabOnload") { 97 } else if (event_name == "Tab.NewTabOnload") {
101 UMA_HISTOGRAM_TIMES("Tab.NewTabOnload", duration); 98 UMA_HISTOGRAM_TIMES("Tab.NewTabOnload", duration);
102 // The new tab page has finished loading; reset it. 99 // The new tab page has finished loading; reset it.
103 CoreTabHelper* core_tab_helper = CoreTabHelper::FromWebContents(tab); 100 CoreTabHelper* core_tab_helper = CoreTabHelper::FromWebContents(tab);
104 core_tab_helper->set_new_tab_start_time(base::TimeTicks()); 101 core_tab_helper->set_new_tab_start_time(base::TimeTicks());
105 } else { 102 } else {
106 NOTREACHED(); 103 NOTREACHED();
107 } 104 }
108 } 105 }
109
110 void MetricsHandler::HandleLogMouseover(const base::ListValue* args) {
111 #if !defined(OS_ANDROID)
112 // Android uses native UI for NTP.
113 NTPUserDataLogger::GetOrCreateFromWebContents(
114 web_ui()->GetWebContents())->LogEvent(NTP_MOUSEOVER,
115 base::TimeDelta::FromMilliseconds(0));
116 #endif // !defined(OS_ANDROID)
117 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/webui/metrics_handler.h ('k') | chrome/browser/ui/webui/ntp/ntp_user_data_logger.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698