Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 2091313003: gclient: fix patch_project handling for the recipe engine (Closed)

Created:
4 years, 6 months ago by Paweł Hajdan Jr.
Modified:
4 years, 6 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M recipe_modules/gclient/config.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Paweł Hajdan Jr.
See https://build.chromium.org/p/tryserver.infra/builders/Recipes-py%20Presubmit/builds/302 for the error I'm hitting.
4 years, 6 months ago (2016-06-24 15:15:38 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2091313003/1
4 years, 6 months ago (2016-06-24 15:15:51 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-24 15:19:03 UTC) #6
tandrii(chromium)
Lgtm This is cause by rename of the project in cq cfg and code review.settings.
4 years, 6 months ago (2016-06-24 15:19:12 UTC) #8
Sergiy Byelozyorov
lgtm
4 years, 6 months ago (2016-06-24 15:20:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2091313003/1
4 years, 6 months ago (2016-06-24 15:23:21 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-24 15:26:40 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/cd0b7abe26783f...

Powered by Google App Engine
This is Rietveld 408576698