Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2091303004: Revert of Flip mac full builders to GN. (Closed)

Created:
4 years, 6 months ago by prasadv
Modified:
4 years, 6 months ago
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Flip mac full builders to GN. (patchset #1 id:1 of https://codereview.chromium.org/2094783003/ ) Reason for revert: Breaking Mac builders on chromium.perf and tryserver.chromium.perf. Original issue's description: > Flip mac full builders to GN. > > This flips the 'Mac' build on the 'chromium' waterfall and the > 'Google Chrome Mac' build on the 'chromium.chrome' waterfall to GN. > If this sticks overnight, we can try to flip the official builders > to GN in the morning. This also flips the 'mac_chromium_archive_rel_ng' > MB config to match the 'Mac' config so that we can test builds more > effectively. > > The official build still isn't "right", since we haven't ported over > the installer for the remoting me2me host. I'm going to try and work > around that for now so that we can see what else might be missing. > > R=rsesek@chromium.org > TBR=zijiehe@chromium.org, sergeyu@chromium.org > BUG=618468 > > Committed: https://crrev.com/63619254507db98dec507b02a4ac09a9a4629009 > Cr-Commit-Position: refs/heads/master@{#401894} TBR=rsesek@chromium.org,zijiehe@chromium.org,sergeyu@chromium.org,dpranke@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=618468

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -19 lines) Patch
M remoting/host/BUILD.gn View 1 chunk +0 lines, -14 lines 0 comments Download
M tools/mb/mb_config.pyl View 4 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
prasadv
Created Revert of Flip mac full builders to GN.
4 years, 6 months ago (2016-06-24 18:50:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2091303004/1
4 years, 6 months ago (2016-06-24 18:50:47 UTC) #3
commit-bot: I haz the power
Failed to apply patch for remoting/host/BUILD.gn: While running git apply --index -3 -p1; error: patch ...
4 years, 6 months ago (2016-06-24 18:51:20 UTC) #5
Robert Sesek
4 years, 6 months ago (2016-06-24 18:52:30 UTC) #7

Powered by Google App Engine
This is Rietveld 408576698