Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(874)

Issue 2091303002: 🎉 Fix missing ninja dependency between .apk and component shared libs (Closed)

Created:
4 years, 6 months ago by agrieve
Modified:
4 years, 6 months ago
Reviewers:
pkotwicz
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix missing ninja dependency between .apk and component shared libs BUG=623054 Committed: https://crrev.com/f762d1c3e6b31608f4c5017dbceacd0e54115e0b Cr-Commit-Position: refs/heads/master@{#401870}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M build/android/gyp/apkbuilder.py View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2091303002/1
4 years, 6 months ago (2016-06-24 14:16:00 UTC) #2
agrieve
4 years, 6 months ago (2016-06-24 14:16:31 UTC) #5
pkotwicz
lgtm
4 years, 6 months ago (2016-06-24 14:29:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2091303002/1
4 years, 6 months ago (2016-06-24 14:36:25 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-24 16:16:59 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-24 16:19:30 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f762d1c3e6b31608f4c5017dbceacd0e54115e0b
Cr-Commit-Position: refs/heads/master@{#401870}

Powered by Google App Engine
This is Rietveld 408576698