Moves a couple of the maximize mode classes to ash/common

Moves a couple of the maximize mode classes to ash/common

BUG=612629
TEST=covered by tests
R=jamescook@chromium.org

Committed: https://crrev.com/45a721f87dda27a3096f0429a409b84ae63ce178
Cr-Commit-Position: refs/heads/master@{#402195}

[James Cook, 2016-06-27 00:19:21]

LGTM

https://codereview.chromium.org/2091263004/diff/20001/ash/aura/wm_window_aura.cc
File ash/aura/wm_window_aura.cc (right):

https://codereview.chromium.org/2091263004/diff/20001/ash/aura/wm_window_aura...
ash/aura/wm_window_aura.cc:457:
window_->ClearProperty(ash::kRestoreShowStateOverrideKey);
nit: "ash::" not needed

https://codereview.chromium.org/2091263004/diff/20001/ash/wm/maximize_mode/ma...
File ash/wm/maximize_mode/maximize_mode_window_state.cc (right):

https://codereview.chromium.org/2091263004/diff/20001/ash/wm/maximize_mode/ma...
ash/wm/maximize_mode/maximize_mode_window_state.cc:244:
window_state->window()->SetRestoreOverrides(gfx::Rect(),
I like that you combined these into a single set/clear method. The fact that the
old code never reset kRestoreShowStateOverrideKey was confusing.

https://codereview.chromium.org/2091263004/diff/20001/ash/wm/maximize_mode/wo...
File ash/wm/maximize_mode/workspace_backdrop_delegate.cc (right):

https://codereview.chromium.org/2091263004/diff/20001/ash/wm/maximize_mode/wo...
ash/wm/maximize_mode/workspace_backdrop_delegate.cc:80: // TODO: this won't work
right with mus: http://crbug.com/548396.
nit: Maybe clarify that "this" means the animations?  (And not the observer.)

[sky, 2016-06-27 15:25:03]

The CQ bit was checked by sky@chromium.org

[sky, 2016-06-27 15:25:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2091263004/#ps60001
(title: "feedback")

[commit-bot: I haz the power, 2016-06-27 15:25:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2016-06-27 15:27:26]

https://codereview.chromium.org/2091263004/diff/20001/ash/aura/wm_window_aura.cc
File ash/aura/wm_window_aura.cc (right):

https://codereview.chromium.org/2091263004/diff/20001/ash/aura/wm_window_aura...
ash/aura/wm_window_aura.cc:457:
window_->ClearProperty(ash::kRestoreShowStateOverrideKey);
On 2016/06/27 00:19:21, James Cook wrote:
> nit: "ash::" not needed

Done.

https://codereview.chromium.org/2091263004/diff/20001/ash/wm/maximize_mode/wo...
File ash/wm/maximize_mode/workspace_backdrop_delegate.cc (right):

https://codereview.chromium.org/2091263004/diff/20001/ash/wm/maximize_mode/wo...
ash/wm/maximize_mode/workspace_backdrop_delegate.cc:80: // TODO: this won't work
right with mus: http://crbug.com/548396.
On 2016/06/27 00:19:21, James Cook wrote:
> nit: Maybe clarify that "this" means the animations?  (And not the observer.)

Done.

[commit-bot: I haz the power, 2016-06-27 16:23:03]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-27 16:24:45]

Description was changed from

==========
Moves a couple of the maximize mode classes to ash/common

BUG=612629
TEST=covered by tests
R=jamescook@chromium.org
==========

to

==========
Moves a couple of the maximize mode classes to ash/common

BUG=612629
TEST=covered by tests
R=jamescook@chromium.org

Committed: https://crrev.com/45a721f87dda27a3096f0429a409b84ae63ce178
Cr-Commit-Position: refs/heads/master@{#402195}
==========

[commit-bot: I haz the power, 2016-06-27 16:24:46]

Patchset 4 (id:??) landed as
https://crrev.com/45a721f87dda27a3096f0429a409b84ae63ce178
Cr-Commit-Position: refs/heads/master@{#402195}