Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: tools/perf/benchmarks/page_cycler_v2.py

Issue 2091183002: [PCv2] Re-enable on desktops (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/page_cycler_v2.py
diff --git a/tools/perf/benchmarks/page_cycler_v2.py b/tools/perf/benchmarks/page_cycler_v2.py
index 5b87c78af00c012b861fa6a97e01c2ecdd270127..3571b73edcebf2d28a4e2b46e24957b3be800e2a 100644
--- a/tools/perf/benchmarks/page_cycler_v2.py
+++ b/tools/perf/benchmarks/page_cycler_v2.py
@@ -31,8 +31,8 @@ class _PageCyclerV2(perf_benchmark.PerfBenchmark):
tbm_options.SetTimelineBasedMetric('firstPaintMetric')
return tbm_options
-# crbug.com/615178, crbug.com/619254, crbug.com/621473
-@benchmark.Disabled('win', 'mac', 'linux', 'reference')
+# crbug.com/619254
+@benchmark.Disabled('reference')
class PageCyclerV2Typical25(_PageCyclerV2):
"""Page load time benchmark for a 25 typical web pages.
@@ -46,10 +46,7 @@ class PageCyclerV2Typical25(_PageCyclerV2):
return 'page_cycler_v2.typical_25'
@classmethod
- def ShouldDisable(cls, possible_browser): # crbug.com/615178
- if (possible_browser.browser_type == 'reference' and
- possible_browser.platform.GetOSName() == 'android'):
- return True
+ def ShouldDisable(cls, possible_browser):
# crbug.com/616781
if (cls.IsSvelte(possible_browser) or
possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X' or
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698