Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(828)

Issue 2091153003: Delete the chromium_gpu_builder and chromium_gpu_debug_builder targets. (Closed)

Created:
4 years, 6 months ago by Ken Russell (switch to Gerrit)
Modified:
4 years, 6 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, Zhenyao Mo
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete the chromium_gpu_builder and chromium_gpu_debug_builder targets. These are no longer referenced. BUG=299367 Committed: https://crrev.com/9e447b2a288eba754dfc477d359840286f69e6a5 Cr-Commit-Position: refs/heads/master@{#401788}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -55 lines) Patch
M build/all.gyp View 1 chunk +0 lines, -55 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Ken Russell (switch to Gerrit)
Dirk: PTAL. Thanks.
4 years, 6 months ago (2016-06-23 23:39:48 UTC) #2
Dirk Pranke
lgtm
4 years, 6 months ago (2016-06-23 23:45:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2091153003/1
4 years, 6 months ago (2016-06-24 00:35:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-24 02:10:59 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9e447b2a288eba754dfc477d359840286f69e6a5 Cr-Commit-Position: refs/heads/master@{#401788}
4 years, 6 months ago (2016-06-24 02:13:58 UTC) #8
stevenjb
4 years, 5 months ago (2016-06-27 16:51:47 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2099353002/ by stevenjb@chromium.org.

The reason for reverting is: khronos_glcts_test is in fact used on Chrome OS. It
is referenced in the ebuild. See crbug.com/623448 for the build failures.
.

Powered by Google App Engine
This is Rietveld 408576698