Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Side by Side Diff: chrome/browser/resources/settings/people_page/quick_unlock_authenticate.html

Issue 2091143002: Add the authenticate screen for the quick unlock settings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pin-unlock-settings-keyboard-fixes
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 <link rel="import" href="chrome://resources/html/polymer.html">
2 <link rel="import" href="chrome://resources/polymer/v1_0/paper-input/paper-input .html">
3 <link rel="import" href="/people_page/quick_unlock_routing_behavior.html">
4 <link rel="import" href="/settings_page/settings_section.html">
5 <link rel="import" href="/settings_shared_css.html">
6
7 <dom-module id="settings-quick-unlock-authenticate">
8 <template>
9 <style include="settings-shared"></style>
10 <style>
11 .middle {
12 flex-grow: 0 !important;
tommycli 2016/06/24 00:56:38 !important is really discouraged. If you don't ne
jdufault 2016/06/29 19:06:38 Done.
13 margin-right: 16px;
14 }
15
16 #password-container {
17 flex-grow: 1;
tommycli 2016/06/24 00:56:38 Does this make the password line span the whole li
jdufault 2016/06/29 19:06:39 I've realigned with mocks and the password line no
18 }
19
20 paper-input {
21 margin-bottom: 22px;
tommycli 2016/06/24 00:56:38 Is this to make the settings box a bit taller? May
jdufault 2016/06/29 19:06:38 I've added some comments and solved the problem di
22 }
23 </style>
24
25 <div>
26 <div class="settings-box">$i18n{quickUnlockConfirmLogin}</div>
27
28 <div class="settings-box first">
29 <div class="middle">
tommycli 2016/06/24 00:56:38 Is the middle class to produce the horizontal line
jdufault 2016/06/29 19:06:39 Removed
30 <span id="profile-name">
31 [[profileName]]
32 </span>
33 </div>
34
35 <span id="password-container" class="secondary-action">
36 <paper-input id="password-input" type="password"
37 label="$i18n{quickUnlockPasswordLabel}"
38 value="{{password_}}"
39 invalid$="[[passwordInvalid_]]"
40 on-change="checkPasswordNow_"
41 on-input="startDelayedPasswordCheck_"
42 error-message="$i18n{quickUnlockInvalidPassword}"
43 aria-disabled="false">
44 </paper-input>
45 </span>
46 </div>
47 </div>
48 </template>
49
50 <script src="quick_unlock_authenticate.js"></script>
51 </dom-module>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698