Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 209113002: Remove unnecessary paintSkiaText wrapper (Closed)

Created:
6 years, 9 months ago by eae
Modified:
6 years, 9 months ago
Reviewers:
dglazkov
CC:
blink-reviews, jamesr, krit, dsinclair, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Visibility:
Public.

Description

Remove unnecessary paintSkiaText wrapper Remove paintSkiaText wrapper function that is no longer needed now that we always have SkTypeface. R=bungeman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169868

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -23 lines) Patch
M Source/platform/fonts/win/SkiaFontWin.cpp View 4 chunks +1 line, -23 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
eae
6 years, 9 months ago (2014-03-22 00:07:11 UTC) #1
eae
6 years, 9 months ago (2014-03-24 15:33:40 UTC) #2
dglazkov
lgtm
6 years, 9 months ago (2014-03-24 15:36:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/209113002/40001
6 years, 9 months ago (2014-03-24 15:36:21 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-24 15:37:37 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_rel
6 years, 9 months ago (2014-03-24 15:37:38 UTC) #6
eae
The CQ bit was checked by eae@chromium.org
6 years, 9 months ago (2014-03-24 15:42:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/209113002/40001
6 years, 9 months ago (2014-03-24 15:42:39 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-24 16:44:35 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-24 16:44:35 UTC) #10
eae
The CQ bit was checked by eae@chromium.org
6 years, 9 months ago (2014-03-24 16:46:31 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/209113002/40001
6 years, 9 months ago (2014-03-24 16:46:33 UTC) #12
commit-bot: I haz the power
6 years, 9 months ago (2014-03-24 17:52:12 UTC) #13
Message was sent while issue was closed. 
Change committed as 169868

Powered by Google App Engine
This is Rietveld 408576698