Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Unified Diff: telemetry/telemetry/internal/story_runner_unittest.py

Issue 2091103003: [Telemetry] Add Benchmark.ShouldTearDownStateAfterEachStorySetRun (Closed) Base URL: git@github.com:catapult-project/catapult@master
Patch Set: do not change default Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: telemetry/telemetry/internal/story_runner_unittest.py
diff --git a/telemetry/telemetry/internal/story_runner_unittest.py b/telemetry/telemetry/internal/story_runner_unittest.py
index 3d6bde18e375f106147c818070621ce8cbd4bf86..2e8e5743634e9a2da60bb734c65415e0bbf349d3 100644
--- a/telemetry/telemetry/internal/story_runner_unittest.py
+++ b/telemetry/telemetry/internal/story_runner_unittest.py
@@ -362,7 +362,7 @@ class StoryRunnerTest(unittest.TestCase):
calls_in_order = GetCallsInOrder() # pylint: disable=no-value-for-parameter
self.assertEquals(EXPECTED_CALLS_IN_ORDER, calls_in_order)
- def testTearDownStateAfterEachStoryRun(self):
+ def testTearDownStateAfterEachStoryOrStorySetRun(self):
class TestSharedStateForTearDown(TestSharedState):
num_of_tear_downs = 0
@@ -383,9 +383,15 @@ class StoryRunnerTest(unittest.TestCase):
TestSharedStateForTearDown.num_of_tear_downs = 0
story_runner.Run(mock.MagicMock(), story_set, self.options, self.results,
- should_tear_down_state_after_each_story_run=True)
+ tear_down_after_story=True)
self.assertEquals(TestSharedStateForTearDown.num_of_tear_downs, 3)
+ self.options.pageset_repeat = 5
+ TestSharedStateForTearDown.num_of_tear_downs = 0
+ story_runner.Run(mock.MagicMock(), story_set, self.options, self.results,
+ tear_down_after_story_set=True)
+ self.assertEquals(TestSharedStateForTearDown.num_of_tear_downs, 5)
+
def testTearDownIsCalledOnceForEachStoryGroupWithPageSetRepeat(self):
self.options.pageset_repeat = 3
fooz_init_call_counter = [0]
« telemetry/telemetry/benchmark.py ('K') | « telemetry/telemetry/internal/story_runner.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698