Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Unified Diff: net/der/parse_values_unittest.cc

Issue 2091103002: Add CheckOCSPDateValid() to net/cert/internal (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add tests for ConvertBaseUTCTime Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« net/der/parse_values.cc ('K') | « net/der/parse_values.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/der/parse_values_unittest.cc
diff --git a/net/der/parse_values_unittest.cc b/net/der/parse_values_unittest.cc
index 07d7541a62e9b54890818802a16d1c160fd3c93e..6a1daec6b2f26f2a9113e0be80e289e6be1675b8 100644
--- a/net/der/parse_values_unittest.cc
+++ b/net/der/parse_values_unittest.cc
@@ -5,6 +5,7 @@
#include <stdint.h>
#include "base/macros.h"
+#include "base/time/time.h"
#include "net/der/parse_values.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -365,6 +366,19 @@ TEST(ParseValuesTest, ParseBitStringSevenOneBitsUnusedBitIsOne) {
EXPECT_FALSE(ParseBitString(Input(kData), &bit_string));
}
+TEST(ParseValuesTest, ConvertBaseUTCTime) {
+ // Fri, 24 Jun 2016 17:04:54 GMT
+ base::Time time =
+ base::Time::UnixEpoch() + base::TimeDelta::FromSeconds(1466787894);
Ryan Sleevi 2016/06/28 17:33:30 What about the edge cases? What about 1600? (< Wi
dadrian 2016/06/29 22:54:03 Done.
+ GeneralizedTime generalized_time = ConvertBaseUTCTime(time);
+ EXPECT_EQ(2016, generalized_time.year);
+ EXPECT_EQ(6, generalized_time.month);
+ EXPECT_EQ(24, generalized_time.day);
+ EXPECT_EQ(17, generalized_time.hours);
+ EXPECT_EQ(4, generalized_time.minutes);
+ EXPECT_EQ(54, generalized_time.seconds);
+}
+
} // namespace test
} // namespace der
} // namespace net
« net/der/parse_values.cc ('K') | « net/der/parse_values.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698