Add CheckOCSPDateValid() to net/cert/internal

net/der/encode_values.cc

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/time/time.h"
+#include "net/der/encode_values.h"
+
+namespace net {
+
+namespace der {
+
+der::GeneralizedTime EncodeTimeAsGeneralizedTime(const base::Time& time) {
+  base::Time::Exploded exploded;
+  time.UTCExplode(&exploded);

[Ryan Sleevi, 2016/07/01 00:49:53]

DESIGN: Check HasValidValues()?

API suggestion:
bool EncodeTimeAsGeneralizedTime(const base::Time& time, der::GeneralizedTime*
generalized_time) {
  if (!time.UTCExplode(&exploded))
    return false;
  ...
}

(In looking at this code, it's not clear to me why we wouldn't just use
base::Time::Exploded, but that's for another day)

[dadrian, 2016/07/01 17:13:43]

UTCExplode is void...what error condition are you referring to here?

[Ryan Sleevi, 2016/07/01 17:58:07]

time.UTCExplode(&exploded);
if (!exploded.HasValidValues())
  return false;

[dadrian, 2016/07/01 18:41:11]

Ah. Done. Will this fix the Windows case / thoughts on how to fix it in tests?

+
+  der::GeneralizedTime result;
+  result.year = exploded.year;
+  result.month = exploded.month;
+  result.day = exploded.day_of_month;
+  result.hours = exploded.hour;
+  result.minutes = exploded.minute;
+  result.seconds = exploded.second;
+  return result;
+}
+
+}  // namespace der
+
+}  // namespace net