Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Unified Diff: chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm

Issue 2091063002: Location bar: make decorations accessible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm
diff --git a/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm b/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm
index f6d97883a0032f8cb26ba55207156d17a7dbfac2..2eb96e614b6681e046e0c669b2ae203377246961 100644
--- a/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm
+++ b/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm
@@ -450,6 +450,20 @@ class NotificationBridge : public AppMenuIconController::Delegate {
locationBarView_.reset(new LocationBarViewMac(locationBar_, commands_,
profile_, browser_));
[locationBar_ setFont:[NSFont systemFontOfSize:14]];
+
+ // Add the location bar's accessibility views as direct subviews of the
+ // toolbar. They are logical children of the location bar, but the location
+ // bar's actual Cocoa control is an NSCell, so it cannot have child views.
+ // The |locationBarView_| is responsible for positioning the accessibility
+ // views.
+ std::vector<NSView*> accessibility_views;
+ locationBarView_->GetDecorationAccessibilityViews(&accessibility_views);
+ for (const auto& view : accessibility_views) {
+ [[self toolbarView] addSubview:view
+ positioned:NSWindowAbove
+ relativeTo:locationBar_];
+ }
+
if (!isModeMaterial) {
[locationBar_ setFont:[NSFont systemFontOfSize:[NSFont systemFontSize]]];
}

Powered by Google App Engine
This is Rietveld 408576698