Location bar: make decorations accessible

Location bar: make decorations accessible

This is somewhat tricky, since decorations are not NSViews themselves, but are
NSImages that LocationBarViewMac draws over the AutocompleteTextFieldCell.
To be focusable and visible to VoiceOver, these decorations need corresponding
NSViews, but since LocationBarDecoration is deliberately Views-like instead
of Cocoa-like, converting LocationBarDecoration to be an NSView subclass
is infeasible. Instead, this CL adds the notion of an "accessibility view",
which is a fully transparent but focusable and activateable NSView that is
positioned over the LocationBarDecoration's drawn image. The accessibility
views appear in the VoiceOver heirarchy and are focusable and useable by
keyboard users.

BUG=613019
Committed: https://crrev.com/cb2b2ec44ef20413e122ae374477a2327bef7dff
Cr-Commit-Position: refs/heads/master@{#401882}

[Elly Fong-Jones, 2016-06-23 19:22:38]

Description was changed from

==========
Location bar: make decorations accessible

This is somewhat tricky, since decorations are not NSViews themselves, but are
NSImages that LocationBarViewMac draws over the AutocompleteTextFieldCell.
To be focusable and visible to VoiceOver, these decorations need corresponding
NSViews, but since LocationBarDecoration is deliberately Views-like instead
of Cocoa-like, converting LocationBarDecoration to be an NSView subclass
is infeasible. Instead, this CL adds the notion of an "accessibility view",
which is a fully transparent but focusable and activateable NSView that is
positioned over the LocationBarDecoration's drawn image. The accessibility
views appear in the VoiceOver heirarchy and are focusable and useable by
keyboard users.

BUG=613019
==========

to

==========
Location bar: make decorations accessible

This is somewhat tricky, since decorations are not NSViews themselves, but are
NSImages that LocationBarViewMac draws over the AutocompleteTextFieldCell.
To be focusable and visible to VoiceOver, these decorations need corresponding
NSViews, but since LocationBarDecoration is deliberately Views-like instead
of Cocoa-like, converting LocationBarDecoration to be an NSView subclass
is infeasible. Instead, this CL adds the notion of an "accessibility view",
which is a fully transparent but focusable and activateable NSView that is
positioned over the LocationBarDecoration's drawn image. The accessibility
views appear in the VoiceOver heirarchy and are focusable and useable by
keyboard users.

BUG=613019
==========

[Elly Fong-Jones, 2016-06-23 19:22:38]

ellyjones@chromium.org changed reviewers:
+ mark@chromium.org

[Elly Fong-Jones, 2016-06-23 19:22:44]

mark: ptal? :)

[Mark Mentovai, 2016-06-23 19:30:56]

It does appear that this would work.

https://codereview.chromium.org/2091063002/diff/1/chrome/browser/ui/cocoa/loc...
File chrome/browser/ui/cocoa/location_bar/location_bar_decoration.h (right):

https://codereview.chromium.org/2091063002/diff/1/chrome/browser/ui/cocoa/loc...
chrome/browser/ui/cocoa/location_bar/location_bar_decoration.h:135: bool
visible_ = false;
I didn’t realize we had started doing this, but it shows up in
https://chromium-cpp.appspot.com/. Cool.

https://codereview.chromium.org/2091063002/diff/1/chrome/browser/ui/cocoa/loc...
File chrome/browser/ui/cocoa/location_bar/location_bar_decoration.mm (right):

https://codereview.chromium.org/2091063002/diff/1/chrome/browser/ui/cocoa/loc...
chrome/browser/ui/cocoa/location_bar/location_bar_decoration.mm:44: -
(id)initWithFrame:(NSRect)frame andOwner:(LocationBarDecoration*)owner {
Is frame ever not NSZeroRect?

https://codereview.chromium.org/2091063002/diff/1/chrome/browser/ui/cocoa/loc...
File chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm (right):

https://codereview.chromium.org/2091063002/diff/1/chrome/browser/ui/cocoa/loc...
chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm:990:
std::vector<LocationBarDecoration*>* decorations) {
Clear the vector on entry to this function and the next one. Or, since you’re a
void return type, you could just make both of these return their vectors.

https://codereview.chromium.org/2091063002/diff/1/chrome/browser/ui/cocoa/loc...
chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm:992: // are page
actions and the keyword hint.
This seems like a lot to keep in sync with (something else) as decorations come
and go. Is there already a central list of these? Does anyone else ever need all
of the decorations?

[Elly Fong-Jones, 2016-06-23 20:25:58]

mark: ptal? :)

https://codereview.chromium.org/2091063002/diff/1/chrome/browser/ui/cocoa/loc...
File chrome/browser/ui/cocoa/location_bar/location_bar_decoration.h (right):

https://codereview.chromium.org/2091063002/diff/1/chrome/browser/ui/cocoa/loc...
chrome/browser/ui/cocoa/location_bar/location_bar_decoration.h:135: bool
visible_ = false;
On 2016/06/23 19:30:55, Mark Mentovai wrote:
> I didn’t realize we had started doing this, but it shows up in
> https://chromium-cpp.appspot.com/. Cool.

Acknowledged.

https://codereview.chromium.org/2091063002/diff/1/chrome/browser/ui/cocoa/loc...
File chrome/browser/ui/cocoa/location_bar/location_bar_decoration.mm (right):

https://codereview.chromium.org/2091063002/diff/1/chrome/browser/ui/cocoa/loc...
chrome/browser/ui/cocoa/location_bar/location_bar_decoration.mm:44: -
(id)initWithFrame:(NSRect)frame andOwner:(LocationBarDecoration*)owner {
On 2016/06/23 19:30:55, Mark Mentovai wrote:
> Is frame ever not NSZeroRect?

Hm. No, it's not. Changed this to not take that argument at all and hardcode
NSZeroRect in the superclass constructor call.

https://codereview.chromium.org/2091063002/diff/1/chrome/browser/ui/cocoa/loc...
File chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm (right):

https://codereview.chromium.org/2091063002/diff/1/chrome/browser/ui/cocoa/loc...
chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm:990:
std::vector<LocationBarDecoration*>* decorations) {
On 2016/06/23 19:30:55, Mark Mentovai wrote:
> Clear the vector on entry to this function and the next one. Or, since you’re
a
> void return type, you could just make both of these return their vectors.

Done.

https://codereview.chromium.org/2091063002/diff/1/chrome/browser/ui/cocoa/loc...
chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm:992: // are page
actions and the keyword hint.
On 2016/06/23 19:30:55, Mark Mentovai wrote:
> This seems like a lot to keep in sync with (something else) as decorations
come
> and go. Is there already a central list of these? Does anyone else ever need
all
> of the decorations?

It doesn't seem so. Most places only need one of the decorations, but some (eg
::Layout and ::Update) use subsets of them.

[Mark Mentovai, 2016-06-23 20:52:30]

LGTM

[Elly Fong-Jones, 2016-06-24 16:07:00]

The CQ bit was checked by ellyjones@chromium.org

[commit-bot: I haz the power, 2016-06-24 16:07:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-24 16:50:00]

Description was changed from

==========
Location bar: make decorations accessible

This is somewhat tricky, since decorations are not NSViews themselves, but are
NSImages that LocationBarViewMac draws over the AutocompleteTextFieldCell.
To be focusable and visible to VoiceOver, these decorations need corresponding
NSViews, but since LocationBarDecoration is deliberately Views-like instead
of Cocoa-like, converting LocationBarDecoration to be an NSView subclass
is infeasible. Instead, this CL adds the notion of an "accessibility view",
which is a fully transparent but focusable and activateable NSView that is
positioned over the LocationBarDecoration's drawn image. The accessibility
views appear in the VoiceOver heirarchy and are focusable and useable by
keyboard users.

BUG=613019
==========

to

==========
Location bar: make decorations accessible

This is somewhat tricky, since decorations are not NSViews themselves, but are
NSImages that LocationBarViewMac draws over the AutocompleteTextFieldCell.
To be focusable and visible to VoiceOver, these decorations need corresponding
NSViews, but since LocationBarDecoration is deliberately Views-like instead
of Cocoa-like, converting LocationBarDecoration to be an NSView subclass
is infeasible. Instead, this CL adds the notion of an "accessibility view",
which is a fully transparent but focusable and activateable NSView that is
positioned over the LocationBarDecoration's drawn image. The accessibility
views appear in the VoiceOver heirarchy and are focusable and useable by
keyboard users.

BUG=613019
==========

[commit-bot: I haz the power, 2016-06-24 16:50:01]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-24 16:51:14]

Description was changed from

==========
Location bar: make decorations accessible

This is somewhat tricky, since decorations are not NSViews themselves, but are
NSImages that LocationBarViewMac draws over the AutocompleteTextFieldCell.
To be focusable and visible to VoiceOver, these decorations need corresponding
NSViews, but since LocationBarDecoration is deliberately Views-like instead
of Cocoa-like, converting LocationBarDecoration to be an NSView subclass
is infeasible. Instead, this CL adds the notion of an "accessibility view",
which is a fully transparent but focusable and activateable NSView that is
positioned over the LocationBarDecoration's drawn image. The accessibility
views appear in the VoiceOver heirarchy and are focusable and useable by
keyboard users.

BUG=613019
==========

to

==========
Location bar: make decorations accessible

This is somewhat tricky, since decorations are not NSViews themselves, but are
NSImages that LocationBarViewMac draws over the AutocompleteTextFieldCell.
To be focusable and visible to VoiceOver, these decorations need corresponding
NSViews, but since LocationBarDecoration is deliberately Views-like instead
of Cocoa-like, converting LocationBarDecoration to be an NSView subclass
is infeasible. Instead, this CL adds the notion of an "accessibility view",
which is a fully transparent but focusable and activateable NSView that is
positioned over the LocationBarDecoration's drawn image. The accessibility
views appear in the VoiceOver heirarchy and are focusable and useable by
keyboard users.

BUG=613019

Committed: https://crrev.com/cb2b2ec44ef20413e122ae374477a2327bef7dff
Cr-Commit-Position: refs/heads/master@{#401882}
==========

[commit-bot: I haz the power, 2016-06-24 16:51:15]

Patchset 2 (id:??) landed as
https://crrev.com/cb2b2ec44ef20413e122ae374477a2327bef7dff
Cr-Commit-Position: refs/heads/master@{#401882}