LayoutTests/media/encrypted-media/encrypted-media-lifetime-mediakeysession-reference.html - Issue 209103002: Add lifetime tests for MediaKeySession

Side by Side Diff: LayoutTests/media/encrypted-media/encrypted-media-lifetime-mediakeysession-reference.html

Issue 209103002: Add lifetime tests for MediaKeySession (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | LayoutTests/media/encrypted-media/encrypted-media-lifetime-mediakeysession-reference-expected.txt » ('j') | LayoutTests/media/encrypted-media/encrypted-media-lifetime-mediakeysession-reference-expected.txt » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <title>Test MediaKeySession lifetime</title>

	5 <script src="../w3c-media-utils.js"></script>

	6 <script src="../../resources/testharness.js"></script>

	7 <script src="../../resources/testharnessreport.js"></script>

	8 <script src="../../resources/gc.js"></script>

	9 </head>

	10 <body>

	11 <video id="testVideo"></video>

	12 <div id="log"></div>

	13 <script>

	14 setup({ timeout: 60000 }); // Timeout for all tests to run.

	15

	16 // Since MediaKeySession (but not MediaKeys) are ActiveDOMObjects,

	17 // we can determine when they are garbage collected.
	xhwang 2014/03/26 20:58:32 I'll be nicer to have a more detailed document lev I'll be nicer to have a more detailed document level description about in which situation should MediaKeys and MediaKeySession be gc'ed, and why. jrummell 2014/03/26 22:19:03 Done. Show quoted text On 2014/03/26 20:58:32, xhwang wrote: > I'll be nicer to have a more detailed document level description about in which > situation should MediaKeys and MediaKeySession be gc'ed, and why. Done.
	18 test(function()

	19 {

	20 var video = document.getElementById("testVideo");
	xhwang 2014/03/26 20:58:32 Since you are using MediaKeys only, no need to use Since you are using MediaKeys only, no need to use "video" here and on l.11? jrummell 2014/03/26 22:19:03 Done. Show quoted text On 2014/03/26 20:58:32, xhwang wrote: > Since you are using MediaKeys only, no need to use "video" here and on l.11? Done.
	21 var initData = new Uint8Array(['n', 'o', 't', 'h', 'i', 'n', 'g' ]);
	xhwang 2014/03/26 20:58:32 This is probably not what you intended. I tried it This is probably not what you intended. I tried it and initData is [0, 0, 0, 0, 0, 0, 0]. Probably you can just do [0, 1, 2, 3, 4, 5, 6]. jrummell 2014/03/26 22:19:03 Done. Show quoted text On 2014/03/26 20:58:32, xhwang wrote: > This is probably not what you intended. I tried it and initData is [0, 0, 0, 0, > 0, 0, 0]. Probably you can just do [0, 1, 2, 3, 4, 5, 6]. Done.
	22 var startingObjects = window.internals.activeDOMObjectCount(docu ment);
	xhwang 2014/03/26 20:58:32 startingActiveDOMObjectsCreated? startingActiveDOMObjectsCreated? jrummell 2014/03/26 22:19:03 Done. Show quoted text On 2014/03/26 20:58:32, xhwang wrote: > startingActiveDOMObjectsCreated? Done.
	23

	24 function numObjectsCreated()
	xhwang 2014/03/26 20:58:32 numActiveDOMObjectsCreated? numActiveDOMObjectsCreated? jrummell 2014/03/26 22:19:03 Done. Show quoted text On 2014/03/26 20:58:32, xhwang wrote: > numActiveDOMObjectsCreated? Done.
	25 {

	26 return window.internals.activeDOMObjectCount(document) - sta rtingObjects;

	27 }

	28

	29 var mediaKeys = new MediaKeys("org.w3.clearkey");

	30 assert_equals(mediaKeys.keySystem, 'org.w3.clearkey');

	31

	32 // Run gc(), should not affect count since MediaKeys are not

	33 // ActiveDOMObjects.
	xhwang 2014/03/26 20:58:32 This is a bit confusing... gc() here should not af This is a bit confusing... gc() here should not affect count regardless of whether MediaKeys is a ActiveDOMObject because all objects are still referenced? jrummell 2014/03/26 22:19:03 Done. Show quoted text On 2014/03/26 20:58:32, xhwang wrote: > This is a bit confusing... gc() here should not affect count regardless of > whether MediaKeys is a ActiveDOMObject because all objects are still referenced? Done.
	34 gc();

	35 assert_equals(numObjectsCreated(), 0, "MediaKeys created an Acti veDOMObject");

	36

	37 // Create 3 sessions.

	38 var mediaKeySession1 = mediaKeys.createSession("video/webm", ini tData);

	39 assert_equals(numObjectsCreated(), 1);

	40 var mediaKeySession2 = mediaKeys.createSession("video/webm", ini tData);

	41 assert_equals(numObjectsCreated(), 2);

	42 var mediaKeySession3 = mediaKeys.createSession("video/webm", ini tData);

	43 assert_equals(numObjectsCreated(), 3);

	44

	45 // Run gc(). All sessions should remain as we have a reference

	46 // to each one.

	47 gc();

	48 assert_equals(numObjectsCreated(), 3);

	49

	50 // Now drop references to 2 of the sessions. Even though we

	51 // don't have a reference, MediaKeys is still around (and the

	52 // sessions aren't closed), so the objects won't be collected.

	53 mediaKeySession2 = null;

	54 mediaKeySession3 = null;

	55 gc();

	56 assert_equals(numObjectsCreated(), 3);

	57

	58 // Now drop the reference to MediaKeys. It and the 2

	59 // unreferenced sessions should be collected. Run gc() twice,

	60 // in case the first pass finds the sessions first, and only

	61 // frees MediaKeys.
	xhwang 2014/03/26 20:58:32 Why gc() will only free MediaKeys if in the first Why gc() will only free MediaKeys if in the first pass it finds the sessions first? Can you explain more on that? jrummell 2014/03/26 22:19:03 Done. Show quoted text On 2014/03/26 20:58:32, xhwang wrote: > Why gc() will only free MediaKeys if in the first pass it finds the sessions > first? Can you explain more on that? Done.
	62 mediaKeys = null;

	63 gc();

	64 gc();

	65 assert_equals(numObjectsCreated(), 1);

	66

	67 // Drop the reference to the first session. It should get

	68 // collected now since MediaKeys is gone.

	69 mediaKeySession1 = null;

	70 gc();

	71 assert_equals(numObjectsCreated(), 0);

	72 }, "MediaKeySession lifetime using references", { timeout: 60000 });
	xhwang 2014/03/26 20:58:32 s/using references/without release()/ ? s/using references/without release()/ ? jrummell 2014/03/26 22:19:03 Done. Show quoted text On 2014/03/26 20:58:32, xhwang wrote: > s/using references/without release()/ ? Done.
	73 </script>

	74 </body>

	75 </html>

OLD	NEW