 Chromium Code Reviews
 Chromium Code Reviews Issue 2091023006:
  Adds EngineGeolocationFeature for Blimp Geolocation project.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master
    
  
    Issue 2091023006:
  Adds EngineGeolocationFeature for Blimp Geolocation project.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: blimp/engine/session/blimp_engine_session.cc | 
| diff --git a/blimp/engine/session/blimp_engine_session.cc b/blimp/engine/session/blimp_engine_session.cc | 
| index 70134b671f01cbcba85f928a93333bf16cd2911b..9e34c08862c5b46e65e4406b5c6eeedc31670e12 100644 | 
| --- a/blimp/engine/session/blimp_engine_session.cc | 
| +++ b/blimp/engine/session/blimp_engine_session.cc | 
| @@ -221,6 +221,7 @@ BlimpEngineSession::BlimpEngineSession( | 
| settings_manager_(settings_manager), | 
| settings_feature_(settings_manager_), | 
| render_widget_feature_(settings_manager_), | 
| + geolocation_feature_(), | 
| 
Wez
2016/07/12 21:35:14
nit: Why include this in the initializer list if i
 
CJ
2016/07/13 21:49:21
Done.
 | 
| net_components_( | 
| new EngineNetworkComponents(net_log, | 
| QuitCurrentMessageLoopClosure())) { | 
| @@ -292,6 +293,10 @@ void BlimpEngineSession::Initialize() { | 
| engine_config_->client_token())); | 
| } | 
| +EngineGeolocationFeature* BlimpEngineSession::GetGeolocationFeature() { | 
| + return &geolocation_feature_; | 
| +} | 
| + | 
| void BlimpEngineSession::GetEnginePortForTesting( | 
| const GetPortCallback& callback) { | 
| content::BrowserThread::PostTaskAndReplyWithResult( | 
| @@ -324,6 +329,9 @@ void BlimpEngineSession::RegisterFeatures() { | 
| render_widget_feature_.set_ime_message_sender( | 
| thread_pipe_manager_->RegisterFeature(BlimpMessage::kIme, | 
| &render_widget_feature_)); | 
| + geolocation_feature_.set_outgoing_message_processor( | 
| + thread_pipe_manager_->RegisterFeature(BlimpMessage::kGeolocation, | 
| + &geolocation_feature_)); | 
| blob_delegate_->set_outgoing_message_processor( | 
| thread_pipe_manager_->RegisterFeature(BlimpMessage::kBlobChannel, | 
| blob_delegate_)); |