Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2242)

Unified Diff: blimp/engine/feature/geolocation/blimp_location_provider.cc

Issue 2091023006: Adds EngineGeolocationFeature for Blimp Geolocation project. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addresses kmarshall's #10 Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/engine/feature/geolocation/blimp_location_provider.cc
diff --git a/blimp/engine/feature/geolocation/blimp_location_provider.cc b/blimp/engine/feature/geolocation/blimp_location_provider.cc
index 23a9a7f0e51b39b2c799e6242e6dc421ed3566da..d42368b1d3fc4a31d8b0d7042f594f632f120c7e 100644
--- a/blimp/engine/feature/geolocation/blimp_location_provider.cc
+++ b/blimp/engine/feature/geolocation/blimp_location_provider.cc
@@ -41,17 +41,25 @@ void BlimpLocationProvider::OnPermissionGranted() {
NOTIMPLEMENTED();
}
-void BlimpLocationProvider::NotifyCallback(
+void BlimpLocationProvider::OnLocationResponse(
const content::Geoposition& position) {
- DCHECK(!callback_.is_null());
+ NotifyCallback(position);
Kevin M 2016/06/29 17:52:55 Pick one: NOTIMPLEMENTED() with nothing else, or a
CJ 2016/07/11 23:21:06 Done.
+ NOTIMPLEMENTED();
+}
- callback_.Run(this, position);
+void BlimpLocationProvider::SetDelegate(
+ BlimpLocationProvider::BlimpLocationProviderDelegate* delegate) {
+ DCHECK(delegate);
+ DCHECK(!delegate);
Kevin M 2016/06/29 17:52:55 Not sure if you intended to do this. ;)
CJ 2016/07/11 23:21:06 oops.
+
+ delegate_ = delegate;
}
-void BlimpLocationProvider::OnLocationResponse(
+void BlimpLocationProvider::NotifyCallback(
const content::Geoposition& position) {
- NotifyCallback(position);
- NOTIMPLEMENTED();
+ DCHECK(!callback_.is_null());
+
+ callback_.Run(this, position);
}
void BlimpLocationProvider::SetUpdateCallback(

Powered by Google App Engine
This is Rietveld 408576698