blimp/engine/BUILD.gn - Issue 2091023006: Adds EngineGeolocationFeature for Blimp Geolocation project.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/engine/BUILD.gn

Issue 2091023006: Adds EngineGeolocationFeature for Blimp Geolocation project. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addresses kmarshall's #10 Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« blimp/common/proto/geolocation.proto ('K') | « blimp/common/proto/tab_control.proto ('k') | blimp/engine/feature/geolocation/blimp_location_provider.h » ('j') | blimp/engine/feature/geolocation/blimp_location_provider.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: blimp/engine/BUILD.gn

diff --git a/blimp/engine/BUILD.gn b/blimp/engine/BUILD.gn

index 32b2b5adcf350e1a4608034c4eff87975dfb6d86..a0e35695f3b53eb9cb4017138f838ebe1f5a7503 100644

--- a/blimp/engine/BUILD.gn

+++ b/blimp/engine/BUILD.gn

@@ -265,6 +265,8 @@ source_set("feature") {

"feature/engine_settings_feature.h",

"feature/geolocation/blimp_location_provider.cc",

"feature/geolocation/blimp_location_provider.h",

+ "feature/geolocation/engine_geolocation_feature.cc",

+ "feature/geolocation/engine_geolocation_feature.h",

]

deps = [

@@ -374,6 +376,7 @@ source_set("test_support") {

deps = [

":app",

"//base",

+ "//testing/gmock",

]

}

@@ -441,10 +444,12 @@ source_set("feature_unit_tests") {

sources = [

"feature/engine_render_widget_feature_unittest.cc",

"feature/engine_settings_feature_unittest.cc",

+ "feature/geolocation/engine_geolocation_feature_unittest.cc",

]

deps = [

":feature",

+ ":test_support",

"//base",

"//base/test:run_all_unittests",

"//base/test:test_support",