blimp/common/create_blimp_message.cc - Issue 2091023006: Adds EngineGeolocationFeature for Blimp Geolocation project.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/common/create_blimp_message.cc

Issue 2091023006: Adds EngineGeolocationFeature for Blimp Geolocation project. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addresses kmarshall's #10 Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: blimp/common/create_blimp_message.cc

diff --git a/blimp/common/create_blimp_message.cc b/blimp/common/create_blimp_message.cc

index 1ee3d1e3c1fbd928d8a82a0773522c6cf694ffd0..f0bcf7f294b27e950932dbce06b49c9fb16a5d87 100644

--- a/blimp/common/create_blimp_message.cc

+++ b/blimp/common/create_blimp_message.cc

@@ -10,6 +10,7 @@

#include "blimp/common/proto/blimp_message.pb.h"

#include "blimp/common/proto/blob_channel.pb.h"

#include "blimp/common/proto/compositor.pb.h"

+#include "blimp/common/proto/geolocation.pb.h"

#include "blimp/common/proto/input.pb.h"

#include "blimp/common/proto/render_widget.pb.h"

#include "blimp/common/proto/settings.pb.h"

@@ -87,6 +88,13 @@ std::unique_ptr<BlimpMessage> CreateBlimpMessage(

return output;

}

+std::unique_ptr<BlimpMessage> CreateBlimpMessage(

+ GeolocationMessage** geolocation_message) {

+ std::unique_ptr<BlimpMessage> output(new BlimpMessage);

Kevin M 2016/06/29 17:52:55 You can use the new function in ptr_util.h: std::m

CJ 2016/07/11 23:21:06 trouble finding std::make_unique. I know about bas

+ *geolocation_message = output->mutable_geolocation();

+ return output;

std::unique_ptr<BlimpMessage> CreateStartConnectionMessage(

const std::string& client_token,

int protocol_version) {

« no previous file with comments | « blimp/common/create_blimp_message.h ('k') | blimp/common/logging.cc » ('j') | blimp/common/proto/geolocation.proto » ('J')