Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(715)

Unified Diff: blimp/engine/BUILD.gn

Issue 2091023006: Adds EngineGeolocationFeature for Blimp Geolocation project. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addresses Wez's #61 comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/engine/BUILD.gn
diff --git a/blimp/engine/BUILD.gn b/blimp/engine/BUILD.gn
index 8c4b0e211de7102e3af435c2e3bcf984267e7dfd..aa0529d26dfbc6132c22926ab649e4cea2d99ec7 100644
--- a/blimp/engine/BUILD.gn
+++ b/blimp/engine/BUILD.gn
@@ -266,6 +266,8 @@ source_set("feature") {
"feature/engine_settings_feature.h",
"feature/geolocation/blimp_location_provider.cc",
"feature/geolocation/blimp_location_provider.h",
+ "feature/geolocation/engine_geolocation_feature.cc",
+ "feature/geolocation/engine_geolocation_feature.h",
]
deps = [
@@ -374,11 +376,15 @@ source_set("test_support") {
sources = [
"app/test_content_main_delegate.cc",
"app/test_content_main_delegate.h",
+ "feature/geolocation/mock_blimp_location_provider_delegate.cc",
+ "feature/geolocation/mock_blimp_location_provider_delegate.h",
]
deps = [
":app",
+ ":feature",
"//base",
+ "//testing/gmock",
]
}
@@ -444,10 +450,13 @@ source_set("feature_unit_tests") {
sources = [
"feature/engine_render_widget_feature_unittest.cc",
"feature/engine_settings_feature_unittest.cc",
+ "feature/geolocation/blimp_location_provider_unittest.cc",
+ "feature/geolocation/engine_geolocation_feature_unittest.cc",
]
deps = [
":feature",
+ ":test_support",
"//base",
"//base/test:test_support",
"//blimp/common",

Powered by Google App Engine
This is Rietveld 408576698